Skip to content

fix(deps, ci, v1.2): bump setup-sbt and playwright - #9133

Merged
mengw15 merged 1 commit into
apache:release/v1.2from
mengw15:fix/9095-bump-setup-sbt-and-playwright-v1.2
Oct 25, 2026
Merged

mengw15 merged 1 commit into
apache:release/v1.2from
mengw15:fix/9095-bump-setup-sbt-and-playwright-v1.2

Conversation

@mengw15

@mengw15 mengw15 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Backport of #9100 to release/v1.2, which it never reached because it had no release/v1.2 label. This branch pins the same sbt/setup-sbt v1.5.7, whose nested carabiner-dev action the ASF actions allowlist dropped, so every job here that sets up sbt fails at Set up job, and so does the image build in build-and-push-images.yml. The ubuntu frontend leg also needs Playwright 1.64.1 on the Ubuntu 26.04 runners.

The cherry-pick conflicted only because benchmarks.yml, dependency-graph.yml and the platform-integration job in build.yml do not exist on this branch. The 6 call sites that do exist move to v1.5.12, and playwright moves to 1.64.1 as in #9100.

Any related issues, documentation, discussions?

Backport of #9100. Originally linked #9095.

How was this PR tested?

yarn install --mode=update-lockfile leaves yarn.lock unchanged, and this PR's own CI runs on the updated workflows.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-5-5)

Nothing can merge into `main` right now. Three CI faults block it, and
each fix needs the others to land first.

```
Before:  Scala job     -> sbt/setup-sbt v1.5.7  -> nested carabiner action not allowed -> fails at Set up job
         frontend job  -> ubuntu-26.04 runner   -> Playwright 1.59.1 has no Chromium    -> fails at install
         merge group   -> no runner within 45 min                -> checks_timed_out, PR leaves the queue
After:   Scala job     -> sbt/setup-sbt v1.5.12 -> every nested action allowed         -> runs
         frontend job  -> ubuntu-26.04 runner   -> Playwright 1.64.1 installs Chromium  -> runs
         merge group   -> waits up to 360 min for runners         -> merges
```

- **setup-sbt.** The ASF actions allowlist dropped the nested
`carabiner-dev/actions/install/*` refs that `sbt/setup-sbt` v1.5.7
reaches, so every job that sets up sbt (`amber`, `amber-integration`,
`platform`, `platform-integration`, `Bench`) has died at *Set up job*
since 2026-10-19. This moves all 9 call sites to v1.5.12, whose whole
chain is allowed. The action's inputs did not change.
- **Playwright.** `ubuntu-latest` now resolves to the Ubuntu 26.04
image, where Playwright 1.59.1 refuses to install Chromium ("Playwright
does not support chromium on ubuntu26.04-x64"), so the ubuntu frontend
leg fails before any test runs. This bumps `playwright` to 1.64.1, which
supports 26.04.
- **Merge queue timeout.** The queue ejects an entry whose required
checks have not reported within `check_response_timeout_minutes`, which
is 45. ASF's shared runners are backed up well past that: in the last
merge group, *Validate PR title*, a 2-second job, waited 110 minutes for
a runner. This raises the limit to 360 minutes, as DataFusion did in
apache/datafusion#26293.

`Required Checks` stays red without both version bumps, and no PR gets
through the queue without the higher limit, so all three go in one PR.

Closes apache#9095.

Every changed file parses:

```
python -I -c "import sys, yaml; [yaml.safe_load(open(f)) for f in sys.argv[1:]]" .asf.yaml .github/workflows/benchmarks.yml .github/workflows/build-and-push-images.yml .github/workflows/build.yml .github/workflows/dependency-graph.yml
```

Walking the `uses:` chain under `sbt/setup-sbt@ecad189` (v1.5.12)
reaches `ampel/verify@32587e8`, `install/ampel@d6d91c5`,
`install/download-and-verify@2fec8bd` and
`install/ampel-bootstrap@16009dc`, and all four are in
`apache/infrastructure-actions`' `approved_patterns.yml` as of
2026-10-23. Under v1.5.7, `install/ampel@2fec8bd`,
`install/download-and-verify@16009dc` and
`install/ampel-bootstrap@619a474` are not.

The rest is CI. The labeler applies `ci` for `.github/**`, which runs
every stack that sets up sbt, the frontend legs, and `Bench`. On this
PR's previous head every job passed except the ubuntu frontend leg,
which landed on ubuntu-26.04 and failed at the Playwright install. The
new timeout only shows once this is merged.

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Ian Maxon <ian@maxons.email>
@mengw15
mengw15 requested a review from xuang7 October 25, 2026 02:54
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Oct 25, 2026
@github-actions github-actions Bot added fix frontend Changes related to the frontend GUI ci changes related to CI labels Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @xuang7
    You can notify them by mentioning @xuang7 in a comment.

@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.48%. Comparing base (19724ee) to head (bdba88e).

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.2    #9133   +/-   ##
===============================================
  Coverage           53.47%   53.48%           
  Complexity           2569     2569           
===============================================
  Files                1078     1078           
  Lines               42359    42359           
  Branches             4563     4563           
===============================================
+ Hits                22651    22655    +4     
+ Misses              18396    18388    -8     
- Partials             1312     1316    +4     
Flag Coverage Δ *Carryforward flag
access-control-service 64.35% <ø> (ø)
agent-service 38.97% <ø> (ø)
amber 53.49% <ø> (ø) Carriedforward from 19724ee
computing-unit-managing-service 1.65% <ø> (ø)
config-service 56.06% <ø> (ø)
file-service 61.72% <ø> (ø)
frontend 47.34% <ø> (+0.02%) ⬆️
pyamber 93.37% <ø> (ø)
python 90.93% <ø> (ø) Carriedforward from 19724ee
workflow-compiling-service 58.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xuang7 xuang7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengw15
mengw15 added this pull request to the merge queue Oct 25, 2026
Merged via the queue into apache:release/v1.2 with commit a95a3da Oct 25, 2026
28 checks passed
@mengw15
mengw15 deleted the fix/9095-bump-setup-sbt-and-playwright-v1.2 branch October 25, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI dependencies Pull requests that update a dependency file fix frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants