Repository navigation
[core] Validate DATE partitions by their date value in partition.timestamp-format.strict - #10874
Merged
JingsongLi merged 1 commit intoNov 1, 2026
Conversation
…stamp-format.strict PartitionTimestampValidator passed DATE partition values to PartitionTimeExtractor as raw epoch-day integers, so the documented 'yyyy-MM-dd' + '$dt' setup failed on every write once partition.timestamp-format.strict was enabled. Convert DATE values to LocalDate first, as PartitionExpireStrategy#convertPartition does. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #10873
partition.timestamp-format.strict=true, the DATE setup documented by [core] Fix expiration of DATE partitions #10464 (yyyy-MM-dd+$dt) fails on every write: the validator sees the epoch day (dt=20755), not the date.PartitionTimestampValidatornow converts DATE values toLocalDate, same asPartitionExpireStrategy#convertPartition([core] Fix expiration of DATE partitions #10464).yyyyMMdd) is still rejected, now with a readable value in the message.Tests
TableWriteTest#testPartitionTimestampValidationWithDatePartition:yyyy-MM-dd+$dtwrites and commits;yyyyMMddthrows withdt=2026-10-29.Partition dt=20755 does not match ....mvn -pl paimon-core clean install(JDK 11, checkstyle and spotless included) passed with 0 failures;PostgresqlCatalogTestwas excluded locally because it needs Docker.