Repository navigation
[core] Validate DATE partition timestamps as dates - #10885
Closed
chenjian2664 wants to merge 1 commit into
Closed
chenjian2664 wants to merge 1 commit into
chenjian2664 wants to merge 1 commit into
Conversation
chenjian2664
marked this pull request as ready for review
October 30, 2026 05:59
Contributor
|
I have now reviewed the earlier #10874 as well. Both PRs fix #10873, and their complete production implementations are identical apart from one explanatory comment. #10874 was opened first and already covers a real write/commit/read plus mismatched-formatter rejection. This PR is technically correct: its 57 targeted write/partition-expiry/extractor tests passed under the normal JDK 8 Maven checks, and CI is green. However, it adds no independent production behavior beyond the earlier PR. Closing this duplicate so the fix stays in one place. Please contribute the useful append/primary-key, pre-epoch/leap-day and mixed-hour regression coverage to #10874 rather than maintain a second implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #10873.
Strict partition timestamp validation receives DATE values as epoch-day integers, so valid date-formatted partitions fail during writes. Convert DATE values to calendar dates before timestamp extraction, matching partition expiration.
Regression coverage includes ordinary append and primary-key tables, formatter/pattern combinations, pre-epoch dates, leap days, and mixed DATE/hour partitions with invalid-hour rejection.
Tests