Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Paginated ListBuckets and ListDirectoryBuckets can call
hasNext()again after the bucket iterator is exhausted, causing another emptyListBucketsRPC.Check the page limit before advancing the iterator, and perform the lookahead only when the page is full. This avoids the repeated fetch on non-empty final pages while preserving continuation tokens and directory-bucket filtering.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16673
How was this patch tested?
ae281be314, before/after applying the patch: one fewerListBucketsRPC on exact and short final pages for both APIs. Continuing pages and unpaginated listing kept the same counts. Response sizes, directory filtering, and token presence were checked; each scenario was repeated.