Conversation
Contributor
Author
|
Before/after tracing on master The attachment includes the reproducer, patches, raw traces with matched RPC client/server spans, audit logs confirming datastream use, and results for #11397. These are real HTTP/OM RPC calls in a non-secure mini-cluster; no latency measurement is claimed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CopyObject fetches source key details to validate the request, then fetches them again when opening the input stream. Open the stream from the existing
OzoneKeyDetailsinstead, avoiding a secondGetKeyInfoRPC in both ordinary and datastream copies.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16658
How was this patch tested?
ae281be314, before/after applying the patch:GetKeyInfodecreased from 2 to 1 per CopyObject for ordinary and datastream copies. Both cases were repeated, and copied contents were verified.Tracing evidence and reproducer.