Conversation
SessionContinuityCoordinator#readTranscriptPage collapses every error that is not a TranscriptPageRequestError into persistence_failed with "Session transcript is unavailable", and returns it as an operation outcome. Because the handler returns instead of throwing, the "[runtime-host] unexpected <operation> failure" log in operation-dispatcher.ts - the only caller of boundedFailureDiagnostic - never runs for this operation. The cause then reaches neither the Runtime Host log, the desktop diagnostic report, nor the Renderer, which falls back to generic copy. Record the cause with boundedFailureDiagnostic before returning the generic outcome. The outcome the caller receives is unchanged. Refs apache#5572 Generated-by: Maka
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionContinuityCoordinator#readTranscriptPagecollapses every error that is not aTranscriptPageRequestErrorintopersistence_failed/ "Session transcript is unavailable", and returns it as an operation outcome. Because the handler returns instead of throwing, the[runtime-host] unexpected <operation> failurelog inoperation-dispatcher.ts— the only caller ofboundedFailureDiagnostic— never runs for this operation. The cause therefore reaches neither the Runtime Host log, the desktop diagnostic report, nor the Renderer, which falls back to generic copy ("任务内容暂时无法刷新,请稍后重试。").This records the cause with
boundedFailureDiagnosticbefore the generic outcome is returned. The outcome the caller receives is unchanged; the only new output is one[runtime-host]log line.Refs #5572
Verification
npm --workspace @maka/runtime-host run typecheck— cleannpx biome checkon both touched files — cleannode --test packages/runtime-host/dist/__tests__/session-continuity-coordinator.test.js— 47/47 passAssertionError(0 pass / 1 fail)The new test injects a reader that fails only on the page path — bootstrap requests carry no
position, page requests always do — then asserts the generic outcome is still returned and thatconsole.errorwas called exactly once with the injected cause:Not run: the full workspace
testsuite.Review focus
Whether logging directly here is right, versus routing it through
onPublicationFailure. The sibling bootstrap path (session-continuity-coordinator.ts:966) callsonPublicationFailureunder a comment saying the failure "has to leave a trace here", but that hook is wired tocontext.requestDrain(execution-composition.ts:925), not a logger — so no trace is emitted there either. That path is deliberately untouched here; it is context for #5572, not part of this change.AI use
Select exactly one:
Tool(s) and scope: Maka (a DeepSeek-backed agent running in Maka Desktop) drafted the log line and the regression test, and ran the verification commands above. The root-cause analysis that motivated the change was reviewed and corrected before this PR by the author.
Checklist
Does this PR entail a change in behavior?