fix(runtime-host): preserve transcript projection diagnostics - #5601
Open
jackeyfaker77 wants to merge 1 commit into
Open
jackeyfaker77 wants to merge 1 commit into
jackeyfaker77 wants to merge 1 commit into
Conversation
Refs apache#5572 Generated-by: Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Durable transcript projection failures currently discard the read model's hard diagnostics and throw only "projection is incomplete". Preserve them in
RuntimeReadModelErrorand include session/invocation context, diagnostic codes, event IDs, and reasons in its message soboundedFailureDiagnosticcan record the cause. Raw diagnostic detail stays out of the message; existing log redaction and truncation still apply. Soft diagnostics remain readable, and client error responses are unchanged.This complements the page/bootstrap logging changes in #5573 and #5600. Test fixtures also close their database stores before cleanup so Windows SQLite locks do not mask assertion failures.
Refs #5572
Verification
unsupported_event,incomplete_event, andtool_use_id_mismatchfailed against the original reader; the soft-diagnostic case passed.npm run build,npm run typecheck,npm run lint, andnpm run format:checkpassed.npm testwas not run.AI use
Tool(s) and scope: Codex implemented the diagnostic preservation and regression tests, fixed test database cleanup, ran validation, and prepared this PR.
Checklist
Does this PR entail a change in behavior?