Repository navigation
asf.yaml: drop integration_id so the Required checks ruleset applies - #1414
Merged
Merged
Conversation
Raw ruleset values reach the API as strings except for a fixed set of
keys, so integration_id: -1 was sent as "-1" and GitHub rejected the
rule ("Invalid property /rules/0"), leaving the ruleset uncreated.
Without it a check may come from any source, as intended.
Generated-by: Claude Opus 5
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required checksruleset from ci: require approval and verify checks via a ruleset #1413 was never created:.asf.yamlprocessing failed withInvalid property /rules/0: data matches no possible input, soapprovalandverifyare currently not required onmain.actor_idamong them) back to integers.integration_idis not in that set, so-1went out as"-1"and the rule failed validation.integration_id. It is optional in the API, and leaving it out means a check may come from any source, which is what-1was meant to say.Test plan: ran the merged and the fixed
.asf.yamlthrough the parser's own_convert_to_boolintswith every scalar loaded as a string, as the parser does: before,integration_id = '-1'; after, every value has the type the Rulesets API expects. After merge, confirm the ruleset appears under the repository's rulesets and no.asf.yamlerror mail arrives.🤖 Generated with Claude Code