Skip to content

asf.yaml: drop required PR reviews on main - #1411

Merged
potiuk merged 1 commit into
mainfrom
relax-required-approvals
Oct 19, 2026
Merged

potiuk merged 1 commit into
mainfrom
relax-required-approvals

Conversation

@potiuk

@potiuk potiuk commented Oct 19, 2026

Copy link
Copy Markdown
Member
  • Removes required_pull_request_reviews from the main branch protection in .asf.yaml.
  • main no longer requires a PR or an approving review; required status checks are unchanged.

Why: As discussed on slack with @dfoulks1

Test plan: .asf.yaml change only; verify branch protection on main after merge.

🤖 Generated with Claude Code

Generated-by: Claude Opus 5

@dfoulks1 dfoulks1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when we can restrict the review by regex I think we'll have something.

@potiuk

potiuk commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

LGTM, when we can restrict the review by regex I think we'll have something.

Not currently possible in GH configuraiton. but I can do a custom test that will fail if the PR will contain allow-list change and have no approval.

@potiuk
potiuk merged commit dfa4b92 into main Oct 19, 2026
7 checks passed
@potiuk
potiuk deleted the relax-required-approvals branch October 19, 2026 16:22
@potiuk

potiuk commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@dfoulks1 Following up on your note above: the custom check is in. #1412 added an approval check that fails any PR touching the allow list (actions.yml, approved_patterns.yml or the Dependabot composite action) until a reviewer with write access approves; other PRs pass it immediately. #1413 and #1414 make it, and verify, required on main through a ruleset in .asf.yaml: admins bypass it for the asfgit sync push, and committers can only bypass it deliberately when merging a PR. So it does what a regex-restricted review would have.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants