Repository navigation
[feature](operator) Persist mutable FE BE and MS configuration - #524
Merged
morningman merged 2 commits intoOct 20, 2026
Merged
Conversation
Preserve mutable runtime configuration on existing safe PVCs while keeping user ConfigMaps unchanged. Record compatibility defaults for existing clusters and provide a verified opt-in migration tool.
This was referenced Oct 20, 2026
Closed
morningman
pushed a commit
that referenced
this pull request
Oct 20, 2026
…rsistence (#523, #524) (#526) * [feature](operator) Persist mutable FE BE and MS configuration (#524) * [feature](operator) Persist mutable FE BE and MS configuration Preserve mutable runtime configuration on existing safe PVCs while keeping user ConfigMaps unchanged. Record compatibility defaults for existing clusters and provide a verified opt-in migration tool. * Retain runtime configuration PVCs during compute group scale-down (cherry picked from commit d4ae3df) * [fix] Use MS state for disaggregated BE decommission (#523) * fix: use MS state for disaggregated BE decommission * Fix MS instance query colon compatibility (cherry picked from commit 7c6de21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Persisted mutable FE/BE settings currently remain in the container filesystem unless their configuration directory is explicitly backed by storage. Pod replacement can therefore lose those settings, including cloud BE heartbeat configuration. MS also persists changes into its base configuration by default, and its entrypoint can overwrite that file from a ConfigMap on restart.
This change adds runtime configuration persistence for DorisCluster FE/BE and DorisDisaggregatedCluster FE/BE/MS:
spec.runtimeConfigPersistence.enabledenables a verified migration.Clusters without suitable existing persistent storage remain unchanged in automatic mode and emit a warning. Explicit enablement requires suitable storage. This change does not provide kernel query admission before a new cloud BE receives its first heartbeat.
Release note
Preserve mutable FE, BE, and MS configuration across Pod replacement using existing safe PVCs. Existing clusters remain unchanged until explicitly migrated.
Check List (For Author)
go test -race ./pkg/common/utils/runtimeconfig -count=1go test ./pkg/controller/... ./pkg/common/utils/resource ./api/... -skip '^Test_ClearResources$' -count=1 -timeout=120sgo test ./pkg/common/utils/runtimeconfig ./pkg/controller ./pkg/common/utils/resource ./pkg/controller/sub_controller/disaggregated_cluster/... ./api/... -count=1 -timeout=120sPYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tools/tests -v(5 tests)go build ./cmd/operator ./cmd/dorisctlgo vet ./pkg/common/utils/runtimeconfig ./pkg/controller/...make generate manifests; shell syntax and diff whitespace checks.Test_ClearResourceswhile waiting for informer cache synchronization and was stopped. The filtered controller suite passed; the FE suite also passed in the unfiltered run. No live Doris rolling-update/scale-out test was performed.doc/operation/runtime_config_persistence.md.DDC scale-down retains the PVC selected for runtime configuration while continuing to clean up cache PVCs. Scaling back to the same ordinal restores persisted overrides and migration markers. Regression tests cover retained configuration claims, cache cleanup, legacy behavior, and invalid storage metadata.