Repository navigation
Conversation
…e#524) * [feature](operator) Persist mutable FE BE and MS configuration Preserve mutable runtime configuration on existing safe PVCs while keeping user ConfigMaps unchanged. Record compatibility defaults for existing clusters and provide a verified opt-in migration tool. * Retain runtime configuration PVCs during compute group scale-down (cherry picked from commit d4ae3df)
* fix: use MS state for disaggregated BE decommission * Fix MS instance query colon compatibility (cherry picked from commit 7c6de21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Backport #524 and #523 to
branch-25.8.0, in their upstream merge order:d4ae3dfe2d19232a936fab5c5ac213ae8147a728): persist mutable FE/BE/MS configuration on existing suitable PVCs, retain runtime configuration PVCs during DDC scale-down, and provide a verified migration tool.7c6de217693c44429a5c49b1cc2041bdf2faae7a): use persisted MS-driven decommission tasks, wait for FE synchronization, and verify backend absence before reducing DDC replicas.Backport adaptations:
Release note
DDC decommission scale-down now uses MS completion and FE synchronization before removing backends and reducing replicas. Mutable FE/BE/MS configuration can survive Pod replacement using suitable existing PVCs. Existing clusters retain their previous configuration behavior until explicitly migrated; migration instructions are included.
Check List (For Author)
Validation:
go test -race ./pkg/common/utils/metaservice ./pkg/common/utils/mysql ./pkg/common/utils/runtimeconfig ./pkg/controller/sub_controller/disaggregated_cluster/computegroups -count=1 -timeout=120sKUBEBUILDER_ASSETS=<local Kubernetes 1.31.0 envtest binaries> go test ./... -skip '^Test_ClearResources$' -count=1 -timeout=120sgo vet ./...go build ./cmd/operator ./cmd/dorisctlPYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tools/tests -v(5 tests)bash -n pkg/common/utils/runtimeconfig/prepare.shmake manifests generatefollowed bygit diff --exit-codegit diff upstream/branch-25.8.0 --checkpasses.Validation limits: the existing
Test_ClearResourcescases were excluded because the original PRs documented informer synchronization hangs. The first suite attempt lacked envtest binaries in the isolated worktree; rerunning with local binaries passed. No live Doris cluster validation was performed.