Repository navigation
ci: Enforce PR limit to 3 for non-committers - #25973
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25973 +/- ##
==========================================
+ Coverage 82.61% 82.62% +0.01%
==========================================
Files 1145 1147 +2
Lines 444325 445128 +803
Branches 444325 445128 +803
==========================================
+ Hits 367066 367774 +708
- Misses 54972 55020 +48
- Partials 22287 22334 +47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
left a comment
There was a problem hiding this comment.
Thank you -- this will be super helpful
|
Should there be a note about this at https://datafusion.apache.org/contributor-guide/index.html? |
Yes. Great call. Specifically I think we should explain we are trying to help focus reviewer time / efforts (and the fewer open pRs by one contributor the more likely we will have time to review them) I am also working on polishing up improving the guidelines here: |
| allow_auto_merge: true | ||
| # auto-delete head branches after being merged | ||
| del_branch_on_merge: true | ||
| # Limit open pull requests per user without write access. |
There was a problem hiding this comment.
can we also explain the rationale here?
Something like "To try and more evenly spread the reviewer bandwidth around" or something like that?
There was a problem hiding this comment.
It's a great explaination, updated.
Rich-T-kid
left a comment
There was a problem hiding this comment.
sounds like a good idea to me! What happens to existing PR's that exceed the 3 pr limit for non asf contributer? do they get closed automatically?
I agree, added.
No, but they can't open new PRs. The current solution is to close/reopen manually to prioritize PRs. |
|
Thank you all for the review. Let's merge it get it tested. |
|
Thanks! |
## Which issue does this PR close? Follows [DataFusion discussion apache#24413](apache#24413). ## Rationale for this change See discussion for the rationale, most people are voting for 'set limit to 3' from the discussion. ## What changes are included in this PR? Enable `github.pull_requests.creation_cap` in `.asf.yaml` and set `max_open_pull_requests` to `3`. - ASF support: [apache/infrastructure-asfyaml#111](apache/infrastructure-asfyaml#111). - Airflow example followed by this change: [apache/airflow#73758](apache/airflow#73758). Whitelist support through `.asf.yaml` is being added in [apache/infrastructure-asfyaml#135](apache/infrastructure-asfyaml#135), which is still open. Before that I think it's possible to do some manual close/reopen, if some contributor have > 3 concurrent PRs that is mergeable. ## What is the testing strategy for this PR? Should work since it's following the pattern in other ASF project above I don't know if it's possible to test before merging ## Are there any user-facing changes? NA
…pache#11560) # Which issue does this PR close? - N/A. # Rationale for this change With coding agents, the number of open PRs now far exceeds our review capacity. The goal of this change is to encourage submitters to help us curate and prepare a small number of high quality PRs, rather than opening many at once, and to help reviewers figure out where to focus their limited time. DataFusion recently adopted the same limit after discussion apache/datafusion#24413 - apache/datafusion#25973. # What changes are included in this PR? 1. Limit users without write access (non committers), to 3 open, non-draft PRs. # Are these changes tested? No. This is configuration consumed by ASF Infra and follows the pattern already in use in DataFusion and Airflow. It is not possible to test before merging. # Are there any significant user-facing changes? No code changes. Contributors without write access will be limited to 3 open, non-draft PRs at a time. --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com>
Which issue does this PR close?
Follows DataFusion discussion #24413.
Rationale for this change
See discussion for the rationale, most people are voting for 'set limit to 3' from the discussion.
What changes are included in this PR?
Enable
github.pull_requests.creation_capin.asf.yamland setmax_open_pull_requeststo3.Whitelist support through
.asf.yamlis being added in apache/infrastructure-asfyaml#135, which is still open. Before that I think it's possible to do some manual close/reopen, if some contributor have > 3 concurrent PRs that is mergeable.What is the testing strategy for this PR?
Should work since it's following the pattern in other ASF project above
I don't know if it's possible to test before merging
Are there any user-facing changes?
NA