Repository navigation
chore: Limit open, non draft PRs to 3 for users without write access - #11560
Conversation
Enable `github.pull_requests.creation_cap` in `.asf.yaml` with `max_open_pull_requests: 3`, following apache/datafusion#25973, and document the limit in CONTRIBUTING.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alamb
changed the title
|
FYI @Jefffrey @sdf-jkl @Rich-T-kid and @etseidl -- let me know if this is a reasonable policy in your mind |
Rich-T-kid
left a comment
Rich-T-kid
left a comment
There was a problem hiding this comment.
I think this is a good idea
+1
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Yes please. I feel like I'm drowning sometimes. And I have taken to defensively assigning myself to new issues so someone doesn't jump the gun and implement something prematurely.
That said, it does seem like the generated PRs are generally higher quality now than a few months back. There's just too many right now.
Yes indeed -- I also feel like I am drowning (but for me, all the time!) |
|
How does the non-draft limitation help? Does that change what CI runs? Otherwise I could just see people rapid-firing non-draft PRs at the repo and still hammer CI. I guess as a reviewer it makes it easier for me to ignore the ones that aren't ready for review, but it doesn't help the CI situation, I don't think. |
There are settings to limit CI runs too. i.e. needs approval from someone with write access to run |
I hope this can also encourage folks to review more as well, and not just generate code. There are many different ways to contribute to open source 😄 |
Yes, this PR is designed to help us find what PRs are in need of review, not to reduce the CI load (though maybe it will if it reduces the number of PRs submitted 🤷 ) |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
an unfortunate side effect will be some of our regular contributors may be affected by this (e.g. those from datafusion)
Jefffrey
added
the
development-process
On the other hand, we can always comment / review PRs while they are draft. I am hoping it will be a good thing for everyone to help focus on only three open PRs at a time. |
|
Thank you everyone -- I will merge this one in and we can see if it makes a difference |
Which issue does this PR close?
Rationale for this change
With coding agents, the number of open PRs now far exceeds our review capacity.
The goal of this change is to encourage submitters to help us curate and prepare a small number of high quality PRs, rather than opening many at once, and to help reviewers figure out where to focus their limited time.
DataFusion recently adopted the same limit after discussion apache/datafusion#24413
What changes are included in this PR?
Are these changes tested?
No. This is configuration consumed by ASF Infra and follows the pattern already in use in DataFusion and Airflow. It is not possible to test before merging.
Are there any significant user-facing changes?
No code changes. Contributors without write access will be limited to 3 open, non-draft PRs at a time.