Skip to content

PostgreSQL: Support CREATE USER MAPPING - #2751

Merged
LucaCappelletti94 merged 3 commits into
mainfrom
upstream/create-user-mapping
Oct 31, 2026
Merged

LucaCappelletti94 merged 3 commits into
mainfrom
upstream/create-user-mapping

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE USER MAPPING FOR app SERVER s OPTIONS ("user" 'remote'), which pg_dump writes for every user mapping, failed with Expected: =, found: app because CREATE USER read MAPPING as a user name. The statement is recognised by USER MAPPING FOR or USER MAPPING IF NOT EXISTS, so CREATE USER mapping still creates a user. The user is a role name or one of USER, CURRENT_ROLE, CURRENT_USER, SESSION_USER and PUBLIC.

https://www.postgresql.org/docs/current/sql-createusermapping.html

@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.41558% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.67%. Comparing base (a368259) to head (64fe4cc).

Files with missing lines Patch % Lines
src/ast/spans.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2751   +/-   ##
=======================================
  Coverage   82.66%   82.67%           
=======================================
  Files          42       42           
  Lines       35660    35737   +77     
  Branches    35660    35737   +77     
=======================================
+ Hits        29480    29547   +67     
- Misses       2659     2671   +12     
+ Partials     3521     3519    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 added enhancement New feature or request api change labels Oct 28, 2026
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/create-user-mapping branch 4 times, most recently from 43b1b50 to 7ab6241 Compare October 29, 2026 18:15
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/create-user-mapping branch 7 times, most recently from dbab394 to dec899f Compare October 31, 2026 08:30
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/create-user-mapping branch from dec899f to 64fe4cc Compare October 31, 2026 09:01
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Thank you @sabir-akhadov-localstack for the review, I will be merging this one now.

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 2d9629f Oct 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants