Repository navigation
Drop CREATE USER MAPPING with the foreign data warning - #210
Merged
Merged
Conversation
LucaCappelletti94
added
the
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apache/datafusion-sqlparser-rs#2751 parses
CREATE USER MAPPINGinto a newStatement::CreateUserMapping, and pg2sqlite's statement match, which has no wildcard on purpose, stopped compiling against sqlparser main.A user mapping only gives the credentials a role uses for a foreign server. SQLite reads nothing but its own file, so no query result depends on it. It now takes the same lossy-drop warning as
CREATE SERVER,CREATE FOREIGN DATA WRAPPERandCREATE FOREIGN TABLE, and the silent-drop sweep lists it among the warned statements.