Skip to content

update numpy to be conditional on python version #40824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
derrickaw wants to merge 1 commit into from
Closed

update numpy to be conditional on python version #40824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdks/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ requires = [
"mypy-protobuf==3.5.0",
# Avoid https://github.com/pypa/virtualenv/issues/2006
"distlib==0.4.4",
# Numpy headers
"numpy>=1.23.2,<2.6.0", # Update setup.py as well.
# Numpy headers - Update setup.py as well.
"numpy>=1.23.2,<2.5.0; python_version < '3.12'",
"numpy>=1.23.2,<2.6.0; python_version >= '3.12'",
# having cython here will create wheels that are platform dependent.
"cython>=3.2.6,<4",
## deps for generating external transform wrappers:
Expand Down
5 changes: 3 additions & 2 deletions sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,9 @@ def get_portability_package_data():
# numpy can have breaking changes in minor versions.
# Use a strict upper bound.
# Increment the lower bound when the minimum Python version is
# updated.
'numpy>=1.23.2,<2.6.0', # Update pyproject.toml as well.
# updated. Update pyproject.toml as well.
'numpy>=1.23.2,<2.5.0; python_version < "3.12"',
'numpy>=1.23.2,<2.6.0; python_version >= "3.12"',
'objsize>=0.6.1,<0.8.0',
'packaging>=22.0',
'pillow>=12.1.1,<14',
Expand Down
Loading