[derrickaw]

No description provided.

[derrickaw]

/gemini review

[derrickaw]

Fixed in #40823 instead

[github-actions]

📋 Review Summary

This PR updates numpy dependency bounds in pyproject.toml and setup.py to conditionally cap numpy<2.5.0 on Python < 3.12 (since NumPy 2.5+ drops support for Python 3.11) while allowing <2.6.0 on Python >= 3.12.

🔍 General Feedback

• The version markers in both pyproject.toml and setup.py are consistent and accurately reflect NumPy's Python version support matrix.
• Please consider updating the PR description to explain the motivation for this change and remove the boilerplate template.
• Minor nit: lines 34 and 35 in sdks/python/pyproject.toml have a single trailing space at the end of the line.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.90%. Comparing base (2213e54) to head (c0ae60f).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #40824       +/-   ##
===========================================
+ Coverage        0   79.90%   +79.90%     
===========================================
  Files           0      493      +493     
  Lines           0    83479    +83479     
===========================================
+ Hits            0    66703    +66703     
- Misses          0    16776    +16776     

Flag	Coverage Δ
python	79.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.