Repository navigation
Set firm upper bound on Python 3.11 numpy - #40823
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR adds an explicit <2.5.0 upper bound for numpy on Python <3.12 (since NumPy 2.5.0+ drops Python 3.11 support) in both setup.py and pyproject.toml. However, sdks/python/pyproject.toml contains stray double quotes that break TOML syntax.
🔍 General Feedback
- The version specifier changes in
sdks/python/setup.pylook good. - In
sdks/python/pyproject.toml, there is a syntax error on both modified lines due to an extra closing quote before; python_version.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR updates sdks/python/pyproject.toml and sdks/python/setup.py to cap the numpy upper bound at <2.5.0 for Python versions prior to 3.12, while maintaining <2.6.0 for Python 3.12+. The previous TOML syntax issue has been resolved and the changes look clean and ready to merge.
🔍 General Feedback
- Environment markers are properly formatted and synchronized between
pyproject.tomlandsetup.py.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40823 +/- ##
===========================================
+ Coverage 0 79.90% +79.90%
===========================================
Files 0 493 +493
Lines 0 83479 +83479
===========================================
+ Hits 0 66703 +66703
- Misses 0 16776 +16776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Explicitly bound Python 3.11 numpy range to avoid 2.5.0+, which does not support 3.11.