Skip to content

Set firm upper bound on Python 3.11 numpy - #40823

Merged
derrickaw merged 3 commits into
apache:masterfrom
jrmccluskey:numpyVersions
Oct 26, 2026
Merged

derrickaw merged 3 commits into
apache:masterfrom
jrmccluskey:numpyVersions

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Explicitly bound Python 3.11 numpy range to avoid 2.5.0+, which does not support 3.11.

@github-actions github-actions Bot added python size/xs XS: <10 lines changed labels Oct 26, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR adds an explicit <2.5.0 upper bound for numpy on Python <3.12 (since NumPy 2.5.0+ drops Python 3.11 support) in both setup.py and pyproject.toml. However, sdks/python/pyproject.toml contains stray double quotes that break TOML syntax.

🔍 General Feedback

  • The version specifier changes in sdks/python/setup.py look good.
  • In sdks/python/pyproject.toml, there is a syntax error on both modified lines due to an extra closing quote before ; python_version.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

Comment thread sdks/python/pyproject.toml Outdated
Comment thread sdks/python/pyproject.toml Outdated
@jrmccluskey

Copy link
Copy Markdown
Contributor Author

/gemini review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates sdks/python/pyproject.toml and sdks/python/setup.py to cap the numpy upper bound at <2.5.0 for Python versions prior to 3.12, while maintaining <2.6.0 for Python 3.12+. The previous TOML syntax issue has been resolved and the changes look clean and ready to merge.

🔍 General Feedback

  • Environment markers are properly formatted and synchronized between pyproject.toml and setup.py.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.90%. Comparing base (2213e54) to head (ec48100).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #40823       +/-   ##
===========================================
+ Coverage        0   79.90%   +79.90%     
===========================================
  Files           0      493      +493     
  Lines           0    83479    +83479     
===========================================
+ Hits            0    66703    +66703     
- Misses          0    16776    +16776     
Flag Coverage Δ
python 79.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.
Backup reviewer: damccorm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
github-actions Bot requested a review from shunping October 26, 2026 21:13
@derrickaw
derrickaw merged commit b9a783a into apache:master Oct 26, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants