Skip to content

[Iceberg] Make streaming metadata assertions deterministic #40781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bvolpato wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Iceberg] Make streaming metadata assertions deterministic #40781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions ...java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/TableMetadataDriverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,28 @@ public void testStreamingMixedExistingAndNonExistentTables() {
.build()
.asView());

// Check the snapshots independently of when consumers read the streaming view.
PAssert.that(checkNotNull(metadataView.getPCollection()))
.satisfies(
snapshots -> {
boolean foundValidTable = false;
for (Object value : snapshots) {
Map<?, ?> snapshot = (Map<?, ?>) value;
assertNotNull(snapshot);
assertTrue(!snapshot.containsKey("default.mixed_missing_table"));
if (snapshot.containsKey("default.mixed_valid_table")) {
SerializableTableSpec spec =
(SerializableTableSpec) snapshot.get("default.mixed_valid_table");
assertNotNull(spec);
assertEquals("default.mixed_valid_table", spec.getTableIdentifierString());
assertEquals(ICEBERG_SCHEMA.asStruct(), spec.getSchema().asStruct());
foundValidTable = true;
}
}
assertTrue("Expected valid table metadata in the snapshots", foundValidTable);
return null;
});

PCollection<String> consumerObserved =
input.apply(
"ConsumeSideInput",
Expand All @@ -731,20 +753,13 @@ public void processElement(
}
Map<String, SerializableTableSpec> viewMap = c.sideInput(metadataView);
assertNotNull(viewMap);
String dest = row.getString("dest");
if ("default.mixed_valid_table".equals(dest)) {
assertNotNull(viewMap.get(dest));
out.output("VALID_TABLE_FOUND");
} else {
assertTrue(!viewMap.containsKey(dest));
out.output("MISSING_TABLE_NOT_FOUND");
}
assertTrue(!viewMap.containsKey("default.mixed_missing_table"));
out.output(data);
}
})
.withSideInputs(metadataView));

PAssert.that(consumerObserved)
.containsInAnyOrder("VALID_TABLE_FOUND", "MISSING_TABLE_NOT_FOUND");
PAssert.that(consumerObserved).containsInAnyOrder("v1", "v2");

pipeline.run();
}
Expand Down
Loading