Skip to content

[Iceberg] Make streaming metadata assertions deterministic - #40781

Open
bvolpato wants to merge 1 commit into
apache:masterfrom
bvolpato:bvolpato/iceberg-metadata-test-clock
Open

bvolpato wants to merge 1 commit into
apache:masterfrom
bvolpato:bvolpato/iceberg-metadata-test-clock

Conversation

@bvolpato

Copy link
Copy Markdown
Contributor

The mixed-table streaming test can read an initial empty side-input pane before valid metadata arrives (example failure). Writers support this through catalog fallback, so first-pane completeness is not a valid test assumption.

Assert that emitted snapshots eventually contain the valid table with the expected identity and schema, and never cache the missing destination. Keep the checks that consumers receive a readable view and both rows proceed.

Reproduced the original failure locally. The revised metadata tests pass under Hadoop 3.3.6 and 3.4.1, along with repeated execution, formatting, and Checkstyle. Negative fixtures confirm that missing valid metadata and an incorrectly cached destination still fail.

@github-actions github-actions Bot added java io iceberg Iceberg IO connector size/s S: 10-49 lines changed labels Oct 25, 2026
@bvolpato
bvolpato marked this pull request as ready for review October 25, 2026 16:20
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label iceberg.
Backup reviewer: ahmedabu98 (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (a8d6afd) to head (55b53af).
⚠️ Report is 74 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #40781       +/-   ##
===========================================
- Coverage   80.04%        0   -80.05%     
===========================================
  Files         490        0      -490     
  Lines       82916        0    -82916     
===========================================
- Hits        66373        0    -66373     
+ Misses      16543        0    -16543     
Flag Coverage Δ
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iceberg Iceberg IO connector io java Next Action: Reviewers size/s S: 10-49 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant