Repository navigation
Temporarily skip Iceberg cdc tests for managed service - #40731
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This PR temporarily excludes the Iceberg CDC integration tests (LakehouseCatalogCdcWriteIT and DeltaLakeToIcebergCdcIT) in dataflowIntegrationTest when enableManagedTransforms is set, until the managed service is upgraded to Beam 2.77. The change is clean, minimal, and consistent with existing enableManagedTransforms handling in sdks/java/io/iceberg/build.gradle.
🔍 General Feedback
- LGTM! No issues identified.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
| includeTestsMatching 'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn' | ||
| includeTestsMatching 'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTable' | ||
| includeTestsMatching 'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTableWithChangeTypeColumn' | ||
| if (!project.hasProperty('enableManagedTransforms')) { // temporary mitigation until managed service upgrades to 2.77 |
There was a problem hiding this comment.
Will this disable the tests for Runner v1 as well ? I noticed that we specifically adjust the test for Runner v1 within the test execution.
There was a problem hiding this comment.
Yeah it disables all CDC tests for managed service suite.
But btw, the same tests run on a separate Dataflow test suite without managed service, so the test you're mentioning will still run there
There was a problem hiding this comment.
Sg. Please also create a Github issue to re-enable and add a TODO here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40731 +/- ##
============================================
+ Coverage 56.16% 65.20% +9.03%
- Complexity 2288 14149 +11861
============================================
Files 1124 1729 +605
Lines 178336 109357 -68979
Branches 1489 11483 +9994
============================================
- Hits 100170 71310 -28860
+ Misses 75645 33771 -41874
- Partials 2521 4276 +1755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Managed service hasn't been upgraded to 2.77 yet, so these tests will be permared until that happens (as expected). Skipping for now to reduce noise
Fixes #34809