Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This PR fixes failures in the IcebergIO Managed Integration Tests on Dataflow workflow by routing the Iceberg CDC integration tests (IcebergCdcWriteBaseIT and DeltaLakeToIcebergCdcIT) to the legacy Dataflow worker when enableManagedTransforms is enabled.
🔍 General Feedback
- The changes in
build.gradleand the CDC IT classes are minimal, well-scoped, and cleanly work around the Runner v2 managed transform issue for CDC tests.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
| PipelineOptions options = TestPipeline.testingPipelineOptions(); | ||
| if (!changeTypeColumn) { | ||
| // Use the legacy worker for managed transforms until the Runner v2 CDC issue is resolved. | ||
| if (!changeTypeColumn || Boolean.getBoolean("beam.test.enableManagedTransforms")) { |
There was a problem hiding this comment.
It's supposed to run with managed, and we should fix that cc: @chamikaramj @ahmedabu98
There was a problem hiding this comment.
Checked that both tests were added in #40230. Since it's never worked. We can add skip them from Dataflow suite for now, to make the test suite back green and avoid further breakage get in unnoticed.
There was a problem hiding this comment.
Skip only runner v2 tests till the Dataflow service is updated to use Beam 2.77.0 for managed transforms please. Runner v1 tests should work and we can re-enable Runner v2 tests in a week or so when the service is updated.
|
Let's do #40731 instead |
Fixes #34809
Successful run:
https://github.com/apache/beam/actions/runs/39759732796