Skip to content

[Flink] Restore source split logs #40354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Sep 30, 2026
Merged

[Flink] Restore source split logs #40354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...he/beam/runners/flink/translation/wrappers/streaming/io/source/FlinkSourceSplitUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,15 @@
import org.apache.beam.sdk.io.Source;
import org.apache.beam.sdk.io.UnboundedSource;
import org.apache.beam.sdk.options.PipelineOptions;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/** Shared Beam source sizing and splitting helpers. */
final class FlinkSourceSplitUtils {
static final long MEBIBYTE = 1024L * 1024L;

private static final Logger LOG = LoggerFactory.getLogger(FlinkSourceSplitUtils.class);

private FlinkSourceSplitUtils() {}

static <T> long estimateBoundedSourceSize(
Expand All @@ -45,13 +49,25 @@ static <T> ArrayList<FlinkSourceSplit<T>> splitBoundedSource(
throws Exception {
long desiredSizeBytes =
getDesiredSizeBytes(boundedSource, pipelineOptions, numSplits, estimatedSizeBytes);
return toFlinkSplits(boundedSource.split(desiredSizeBytes, pipelineOptions));
List<? extends BoundedSource<T>> splits =
boundedSource.split(desiredSizeBytes, pipelineOptions);
LOG.info(
"Split bounded source {} in {} splits (estimated size {} bytes, "
+ "desired split size {} bytes)",
boundedSource,
splits.size(),
estimatedSizeBytes,
desiredSizeBytes);
return toFlinkSplits(splits);
}

static <T> ArrayList<FlinkSourceSplit<T>> splitUnboundedSource(
UnboundedSource<T, ?> unboundedSource, PipelineOptions pipelineOptions, int numSplits)
throws Exception {
return toFlinkSplits(unboundedSource.split(numSplits, pipelineOptions));
List<? extends UnboundedSource<T, ?>> splits =
unboundedSource.split(numSplits, pipelineOptions);
LOG.info("Split source {} to {} splits", unboundedSource, splits);
return toFlinkSplits(splits);
}

static long getDesiredSizeBytes(
Expand Down
5 changes: 0 additions & 5 deletions ...s/flink/translation/wrappers/streaming/io/source/SizeBasedFlinkSourceSplitEnumerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ private FlinkSourceEnumeratorState<T> selectAndSplit() throws Exception {
ArrayList<FlinkSourceSplit<T>> splits =
FlinkSourceSplitUtils.splitBoundedSource(
boundedSource, pipelineOptions, numSplits, estimatedSizeBytes);
LOG.info(
"Split bounded source {} into {} splits using {} assignment",
boundedSource,
splits.size(),
selectedMode);
return new FlinkSourceEnumeratorState<>(selectedMode, splits);
}

Expand Down
Loading