Repository navigation
[Flink] Restore source split logs - #40354
Merged
Abacn merged 1 commit intoSep 30, 2026
Merged
Conversation
The move of source splitting into FlinkSourceSplitUtils dropped the split-count logs from the default and lazy enumerators. Log in the shared helpers so every enumerator reports how many splits a source produced, and remove the now-duplicate size-based enumerator log.
pkuzmickas
marked this pull request as ready for review
September 30, 2026 12:56
Contributor
Author
|
Hey @Abacn could you please take a look? 🙏 I accidentally removed this in the previous PR we merged. |
Contributor
|
Assigning reviewers: R: @chamikaramj added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
jto
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the source split logs in the Flink DataStream runner that #39874 removed when it moved splitting into
FlinkSourceSplitUtils.Before #39874, the static and lazy enumerators logged:
Split bounded source {} in {} splitsSplit source {} to {} splits(unbounded)After the refactor, only the opt-in size-based enumerator logged split counts. The default lazy and static paths logged nothing about splitting.
Why
These logs are the main way to diagnose source skew in batch jobs. For example, comparing the split count with the source parallelism shows whether a source produces too few splits to distribute work evenly.
Changes
FlinkSourceSplitUtils.splitBoundedSource/splitUnboundedSource, so every enumerator emits the log.CHANGES.mdentry needed.