Skip to content

[Python] Fix overflow in LexicographicKeyRangeTracker #40330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 1 commit into from
Sep 29, 2026
Merged

[Python] Fix overflow in LexicographicKeyRangeTracker #40330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/io/range_trackers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def position_to_fraction(
istart = cls._bytestring_to_int(start, prec)
ikey = cls._bytestring_to_int(key, prec)
iend = cls._bytestring_to_int(end, prec) if end else 1 << (prec * 8)
return float(ikey - istart) / (iend - istart)
return (ikey - istart) / (iend - istart)

@staticmethod
def _bytestring_to_int(s: Union[bytes, str], prec: int) -> int:
Expand Down
7 changes: 7 additions & 0 deletions sdks/python/apache_beam/io/range_trackers_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,13 @@ def test_key_to_fraction_common_prefix(self):
end='a' * 100 + 'e',
fraction=1.0)

def test_key_to_fraction_long_keys(self):
for start, key, end in (
(b'a' * 400, b'm' * 400, b'z' * 400),
('a' * 400, 'm' * 400, 'z' * 400)):
with self.subTest(key_type=type(key).__name__):
self.assertAlmostEqual(0.48, self.key_to_fraction(key, start, end))

def test_tiny(self):
# test bytes keys
self._check(fraction=.5**20, key=b'\0\0\x10')
Expand Down
Loading