Repository navigation
[Python] Fix overflow in LexicographicKeyRangeTracker - #40330
Merged
jrmccluskey merged 1 commit intoSep 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40330 +/- ##
============================================
- Coverage 56.16% 56.15% -0.01%
Complexity 2290 2290
============================================
Files 1121 1121
Lines 177158 177158
Branches 1486 1486
============================================
- Hits 99494 99481 -13
- Misses 75143 75156 +13
Partials 2521 2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
retest this please |
jrmccluskey
approved these changes
Sep 29, 2026
jrmccluskey
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Will merge after the precommit re-run finishes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26492
Long MongoDB string IDs can overflow when
LexicographicKeyRangeTrackerconverts the integer delta tofloatbefore division.This uses Python 3 true division directly and adds regression coverage for long
bytesandstrkeys.Before: 400-character keys raise
OverflowError: int too large to convert to float.After: the same keys return the expected fraction (
0.48).Tests:
python -m unittest -q apache_beam.io.range_trackers_test— 28 passedpython -m unittest -q apache_beam.io.mongodbio_test— 131 passed