Repository navigation
[Iceberg CDC sink] Integration tests - #40230
Conversation
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40230 +/- ##
============================================
+ Coverage 56.14% 58.62% +2.47%
- Complexity 2288 13798 +11510
============================================
Files 1121 2579 +1458
Lines 177152 270217 +93065
Branches 1488 11192 +9704
============================================
+ Hits 99467 158406 +58939
- Misses 75161 105788 +30627
- Partials 2524 6023 +3499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| // CDC sink. The native-ValueKind round trip tests run on legacy worker. | ||
| // The change-type-column tests run on Runner v2. | ||
| includeTestsMatching 'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSource' | ||
| includeTestsMatching 'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn' |
There was a problem hiding this comment.
There are two tests never worked:
-
changeFeedAppliesToIcebergTableWithChangeTypeColumn
-
changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn
e.g. https://github.com/apache/beam/actions/runs/39764361133/job/119776009999
There was a problem hiding this comment.
They're passing on the regular Dataflow test suite (green)
Failing on managed service tests because the service hasn't upgraded to 2.77 yet
| * relies on it drops the Runner v2 experiments and runs on the legacy worker there. This is a | ||
| * no-op for other runners. | ||
| */ | ||
| public static void useLegacyDataflowWorker(PipelineOptions options) { |
There was a problem hiding this comment.
This hacky override made test pass but user still see the use case breaking in default options (managed transform enabled), as it happened in Dataflow tests. We should disable runner v2 when ValueKind and other runner capability not supported by portable runner
Adding some end-to-end testing for the new CDC sink.
Includes roundtrip tests through the Iceberg CDC source.
Includes a Delta -> Iceberg CDC test
Part of #39979
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.