Skip to content

GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 #54608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Oct 20, 2026
Merged

GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 #54608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d7108
GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to co…
raulcd Oct 19, 2026
5fcef5d
Add changes to deb_gir_suffix_substitute_pattern to over s3 too
raulcd Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/release/utils-prepare.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ update_deb_package_names() {
${target} \
$(echo ${target} | sed -e "s/${deb_lib_suffix}/${next_deb_lib_suffix}/")
done
local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"

@kou kou Oct 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update

arrow/dev/release/utils-prepare.sh

Line 236 in fb767a7

local deb_gir_suffix_substitute_pattern="s/(gir1\\.2-(arrow|gandiva|parquet)[-a-z]*)${deb_gir_suffix}/\\1${next_deb_gir_suffix}/g"
? We will add gir1.2-arrow-s3-27.0.install later.

@raulcd raulcd Oct 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou this should be covered now on: 5fcef5d

@kou kou Oct 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sed -i.bak -E -e "${deb_lib_suffix_substitute_pattern}" debian*/control*
rm -f debian*/control*.bak
git add debian*/control*
Expand All @@ -233,7 +233,7 @@ update_deb_package_names() {
${target} \
$(echo ${target} | sed -e "s/${deb_gir_suffix}/${next_deb_gir_suffix}/")
done
local deb_gir_suffix_substitute_pattern="s/(gir1\\.2-(arrow|gandiva|parquet)[-a-z]*)${deb_gir_suffix}/\\1${next_deb_gir_suffix}/g"
local deb_gir_suffix_substitute_pattern="s/(gir1\\.2-(arrow|gandiva|parquet)[-a-z0-9]*)${deb_gir_suffix}/\\1${next_deb_gir_suffix}/g"
sed -i.bak -E -e "${deb_gir_suffix_substitute_pattern}" debian*/control*
rm -f debian*/control*.bak
git add debian*/control*
Expand Down
4 changes: 2 additions & 2 deletions dev/tasks/linux-packages/apache-arrow/debian/control.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Description: Apache Arrow is a data processing library for analysis
.
This package provides C++ library files for Dataset module.

Package: libarrow-s3-2600
Package: libarrow-s3-2700
Section: libs
Architecture: any
Multi-Arch: same
Expand Down Expand Up @@ -257,7 +257,7 @@ Architecture: any
Multi-Arch: same
Depends:
${misc:Depends},
libarrow-s3-2600 (= ${binary:Version}),
libarrow-s3-2700 (= ${binary:Version}),
libarrow-dev (= ${binary:Version})
Description: Apache Arrow is a data processing library for analysis
.
Expand Down
Loading