Repository navigation
GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 - #54608
Merged
Merged
Conversation
… to cover the 3 on libarrow_s3
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes resolve the package mismatch and future bump handling, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes Debian packaging failures from #54595 by correcting S3 package references and ensuring future version bumps include names containing digits.
Changes:
- Updates S3 runtime and development dependency references to
libarrow-s3-2700. - Extends the release-script regex to match digits in package names.
| File | Description |
|---|---|
| dev/tasks/linux-packages/apache-arrow/debian/control.in | Corrects both S3 package references. |
| dev/release/utils-prepare.sh | Includes numeric package-name components in version bumps. |
Review effort: Balanced
kou
approved these changes
Oct 19, 2026
| $(echo ${target} | sed -e "s/${deb_lib_suffix}/${next_deb_lib_suffix}/") | ||
| done | ||
| local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g" | ||
| local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g" |
Member
There was a problem hiding this comment.
Could you also update
arrow/dev/release/utils-prepare.sh
Line 236 in fb767a7
gir1.2-arrow-s3-27.0.install later.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Linux packaging jobs for Deb packages are currently failing due to wrong libarrow_s32600 still being referred to.
What changes are included in this PR?
Update regex to cover numbers on libarrowxxx package names.
Update the wrong entries at control.in.
Are these changes tested?
I have tested the regex locally with:
And validated the diff contains libarrow s3 updated:
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
libarrow-s3-2600#54595