Skip to content

GH-54595: [Packaging][CI] Fix regex on update_deb_package_names to cover the 3 on libarrow_s3 - #54608

Merged
kou merged 2 commits into
apache:mainfrom
raulcd:GH-54595
Oct 20, 2026
Merged

kou merged 2 commits into
apache:mainfrom
raulcd:GH-54595

Conversation

@raulcd

@raulcd raulcd commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

Linux packaging jobs for Deb packages are currently failing due to wrong libarrow_s32600 still being referred to.

What changes are included in this PR?

Update regex to cover numbers on libarrowxxx package names.
Update the wrong entries at control.in.

Are these changes tested?

I have tested the regex locally with:

 $ sed -i.bak -E -e  "s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)2700/\\12800/g" dev/tasks/linux-packages/apache-arrow/debian/control.in

And validated the diff contains libarrow s3 updated:

@@ -122,13 +122,13 @@ Pre-Depends: ${misc:Pre-Depends}
 Depends:
   ${misc:Depends},
   ${shlibs:Depends},
-  libarrow-acero2700 (= ${binary:Version}),
-  libparquet2700 (= ${binary:Version})
+  libarrow-acero2800 (= ${binary:Version}),
+  libparquet2800 (= ${binary:Version})
 Description: Apache Arrow is a data processing library for analysis
  .
  This package provides C++ library files for Dataset module.
 
-Package: libarrow-s3-2700
+Package: libarrow-s3-2800
 Section: libs
 Architecture: any
 Multi-Arch: same

Are there any user-facing changes?

No

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Copilot AI balanced review requested due to automatic review settings October 19, 2026 09:59
@raulcd raulcd added the CI: Extra: Package: Linux Run extra Linux Packages CI label Oct 19, 2026
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes resolve the package mismatch and future bump handling, with no unresolved findings.

No open issues 🎉

What changed in this PR

Fixes Debian packaging failures from #54595 by correcting S3 package references and ensuring future version bumps include names containing digits.

Changes:

  • Updates S3 runtime and development dependency references to libarrow-s3-2700.
  • Extends the release-script regex to match digits in package names.
File Description
dev/​tasks/​linux-packages/​apache-arrow/​debian/​control.in Corrects both S3 package references.
dev/​release/​utils-prepare.sh Includes numeric package-name components in version bumps.

Review effort: Balanced

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

$(echo ${target} | sed -e "s/${deb_lib_suffix}/${next_deb_lib_suffix}/")
done
local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"
local deb_lib_suffix_substitute_pattern="s/(lib(arrow|gandiva|parquet)[-a-z0-9]*)${deb_lib_suffix}/\\1${next_deb_lib_suffix}/g"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update

local deb_gir_suffix_substitute_pattern="s/(gir1\\.2-(arrow|gandiva|parquet)[-a-z]*)${deb_gir_suffix}/\\1${next_deb_gir_suffix}/g"
? We will add gir1.2-arrow-s3-27.0.install later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou this should be covered now on: 5fcef5d

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 19, 2026
Copilot AI balanced review requested due to automatic review settings October 19, 2026 13:49
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted changes address the reported failure, with representative substitution checks passing and no unresolved findings.

No open issues 🎉

Review effort: Balanced

@kou
kou merged commit ee38221 into apache:main Oct 20, 2026
76 of 77 checks passed
@kou kou removed the awaiting changes Awaiting changes label Oct 20, 2026
@github-actions github-actions Bot added the awaiting changes Awaiting changes label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes CI: Extra: Package: Linux Run extra Linux Packages CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants