Skip to content

feat(pages): serve install scripts from custom domain - #797

Merged
lizhengfeng101 merged 2 commits into
alibaba:mainfrom
amh1k:feat/pages-install-scripts
Aug 14, 2026
Merged

feat(pages): serve install scripts from custom domain#797
lizhengfeng101 merged 2 commits into
alibaba:mainfrom
amh1k:feat/pages-install-scripts

Conversation

@amh1k

@amh1k amh1k commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Description

Serve the OCR installation scripts from the project’s custom domain.

The Pages deployment now publishes install.sh and install.ps1 at:

  • https://open-codereview.ai/install.sh
  • https://open-codereview.ai/install.ps1

All installer documentation and usage comments were updated to use the shorter URLs. The existing installer and release-download logic remains unchanged.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)
  • Documentation update
  • CI / Build / Tooling

How Has This Been Tested?

  • make test passes locally
  • Manual testing:
    • sh -n install.sh
    • npm run typecheck
    • npm run build
    • Verified both scripts are copied into the deployment artifact
    • Verified copied scripts match the repository versions with cmp
    • Verified no old installer URLs remain
    • make check
    • git diff --check

Checklist

  • My code follows the project's coding style (go fmt, go vet)
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have signed the CLA

Related Issues

Closes #411

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s).

@wu21-web wu21-web left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is neat and great! Thank you.
Russian docs are still pending for changes: pages/src/content/docs/ru/installation.md

Comment on lines +52 to +55
test -f _site/install.sh
test -f _site/install.ps1
cmp install.sh _site/install.sh
cmp install.ps1 _site/install.ps1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test -f _site/install.sh
test -f _site/install.ps1
cmp install.sh _site/install.sh
cmp install.ps1 _site/install.ps1
test -f _site/install.sh
test -f _site/install.ps1
sh -n _site/install.sh
cmp install.sh _site/install.sh
cmp install.ps1 _site/install.ps1

Scripts not justified by /bin/sh. After that, consider also linting the pwsh script.

amh1k and others added 2 commits August 14, 2026 15:48
- Update Russian installation docs to use open-codereview.ai URLs
- Add sh -n syntax validation in deploy workflow per review feedback
@lizhengfeng101
lizhengfeng101 force-pushed the feat/pages-install-scripts branch from ed752f8 to 53baf27 Compare August 14, 2026 07:49

@lizhengfeng101 lizhengfeng101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu21-web

Copy link
Copy Markdown
Contributor

Why not add a job to justify the .ps1 too?

lizhengfeng101

This comment was marked as outdated.

@lizhengfeng101

Copy link
Copy Markdown
Contributor

Good call — I actually tried this out. Added a separate verify-ps1 job with mcr.microsoft.com/powershell:lts-debian-12 to run [scriptblock]::Create(...) as a parse check, then reverted it.

The cost just doesn't justify the value here: pulling a ~200MB PowerShell container image on every deploy for a single parse check on a file that rarely changes feels like overkill. The sh -n check for install.sh is essentially free (sh is already in the build container), but there's no equivalent zero-cost option for .ps1 in our current setup.

If the script grows more complex or changes frequently in the future we can revisit, but for now I'll leave it as-is.

@lizhengfeng101
lizhengfeng101 merged commit f1c79be into alibaba:main Aug 14, 2026
13 checks passed
@wu21-web

wu21-web commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Do your require all jobs to run on self-hosted runners, even if a job proceeds for a relatively short amount of time (2sec) and uses a cheap runner (ubuntu-latest: $0.006/min)?

Githab-capibara added a commit to Githab-capibara/open-code-review that referenced this pull request Aug 23, 2026
* feat(pages): serve install scripts from custom domain

* fix: update ru/installation.md URLs and add sh -n syntax check

- Update Russian installation docs to use open-codereview.ai URLs
- Add sh -n syntax validation in deploy workflow per review feedback

---------

Co-authored-by: kite <lizhengfeng.lzf@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(pages): serve install scripts from the custom domain (open-codereview.ai/install.sh)

3 participants