feat(pages): serve install scripts from custom domain - #797
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s). |
wu21-web
left a comment
There was a problem hiding this comment.
This implementation is neat and great! Thank you.
Russian docs are still pending for changes: pages/src/content/docs/ru/installation.md
| test -f _site/install.sh | ||
| test -f _site/install.ps1 | ||
| cmp install.sh _site/install.sh | ||
| cmp install.ps1 _site/install.ps1 |
There was a problem hiding this comment.
| test -f _site/install.sh | |
| test -f _site/install.ps1 | |
| cmp install.sh _site/install.sh | |
| cmp install.ps1 _site/install.ps1 | |
| test -f _site/install.sh | |
| test -f _site/install.ps1 | |
| sh -n _site/install.sh | |
| cmp install.sh _site/install.sh | |
| cmp install.ps1 _site/install.ps1 |
Scripts not justified by /bin/sh. After that, consider also linting the pwsh script.
- Update Russian installation docs to use open-codereview.ai URLs - Add sh -n syntax validation in deploy workflow per review feedback
ed752f8 to
53baf27
Compare
|
Why not add a job to justify the .ps1 too? |
|
Good call — I actually tried this out. Added a separate The cost just doesn't justify the value here: pulling a ~200MB PowerShell container image on every deploy for a single parse check on a file that rarely changes feels like overkill. The If the script grows more complex or changes frequently in the future we can revisit, but for now I'll leave it as-is. |
|
Do your require all jobs to run on self-hosted runners, even if a job proceeds for a relatively short amount of time (2sec) and uses a cheap runner (ubuntu-latest: $0.006/min)? |
* feat(pages): serve install scripts from custom domain * fix: update ru/installation.md URLs and add sh -n syntax check - Update Russian installation docs to use open-codereview.ai URLs - Add sh -n syntax validation in deploy workflow per review feedback --------- Co-authored-by: kite <lizhengfeng.lzf@alibaba-inc.com>
Description
Serve the OCR installation scripts from the project’s custom domain.
The Pages deployment now publishes
install.shandinstall.ps1at:https://open-codereview.ai/install.shhttps://open-codereview.ai/install.ps1All installer documentation and usage comments were updated to use the shorter URLs. The existing installer and release-download logic remains unchanged.
Type of Change
How Has This Been Tested?
make testpasses locallysh -n install.shnpm run typechecknpm run buildcmpmake checkgit diff --checkChecklist
go fmt,go vet)Related Issues
Closes #411