chore: lint install.ps1 on pages deployment - #910
Draft
wu21-web wants to merge 7 commits into
Draft
Conversation
Contributor
|
🔍 OpenCodeReview found 5 issue(s) in this PR.
|
wu21-web
marked this pull request as ready for review
August 15, 2026 06:52
wu21-web
marked this pull request as draft
August 15, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #797
Note
This is NOT the only solution, reviews and changes are welcome.
If this is only going towards the wrong direction, please keep this pull request open.
Plan A: Use a seperate lint job to lint the .ps1 on ubuntu-latest with pwsh <--- Current
Plan B: Migrate the whole build step to ubuntu-latest with pwsh
Plan C: Using a self-hosted runner+image
Type of Change
How Has This Been Tested?
make testpasses locallyChecklist
go fmt,go vet)Related Issues
None yet