Skip to content

chore: lint install.ps1 on pages deployment - #910

Draft
wu21-web wants to merge 7 commits into
alibaba:mainfrom
wu21-web:patch-1
Draft

chore: lint install.ps1 on pages deployment#910
wu21-web wants to merge 7 commits into
alibaba:mainfrom
wu21-web:patch-1

Conversation

@wu21-web

@wu21-web wu21-web commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

Follow up to #797

Note

This is NOT the only solution, reviews and changes are welcome.
If this is only going towards the wrong direction, please keep this pull request open.

Plan A: Use a seperate lint job to lint the .ps1 on ubuntu-latest with pwsh <--- Current
Plan B: Migrate the whole build step to ubuntu-latest with pwsh
Plan C: Using a self-hosted runner+image

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)
  • Documentation update
  • CI / Build / Tooling

How Has This Been Tested?

  • make test passes locally
  • Manual testing (describe below)

Checklist

  • My code follows the project's coding style (go fmt, go vet)
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if applicable)
  • I have signed the CLA

Related Issues

None yet

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🔍 OpenCodeReview found 5 issue(s) in this PR.

  • ✅ Successfully posted inline: 5 comment(s)

Comment thread .github/workflows/deploy-pages.yml Outdated
Comment thread .github/workflows/deploy-pages.yml Outdated
Comment thread .github/workflows/deploy-pages.yml Outdated
Comment thread .github/workflows/deploy-pages.yml Outdated
Comment thread .github/workflows/deploy-pages.yml Outdated
@wu21-web
wu21-web marked this pull request as ready for review August 15, 2026 06:52
@wu21-web
wu21-web marked this pull request as draft August 15, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant