Repository navigation
FORMS-28607: Consume af-core 1.0.10 and cover legacy custom-function access - #2009
Merged
Merged
Conversation
Add runtime-only coverage for the legacy _options.parent._setProperty chain. Use the maintained IT page so repeated previews retain working custom-function registration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 of 10 tasks
rismehta
added a commit
that referenced
this pull request
Oct 23, 2026
* fix(tests): isolate telephone policy authoring from component insertion Reuse the existing telephone field with the same default policy, wait for policy save and verify persisted custom patterns before editor navigation, and clean up prepared policy attempts. Keep shared insertion commands unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): synchronize blank-page telephone policy authoring Preserve insertion of a new telephone field into the blank form. Await policy persistence, actual layer transitions and insertion events; query only the visible insertion dialog and re-query its search input after clearing. Preserve original assertions and wait for the edit dialog to close before cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix shared authoring synchronization and flaky Sites replacement tests Retry opening the Insert dialog after lost actions, target only visible dialog controls, and wait for layer, insertion and replacement refreshes. Restore the original replace-group policy state using existing editor helpers and named actions. Add a deterministic lost-Insert-click regression with delayed persistence responses. Validation: five Chrome repeats (25 passing), Electron Sites/Forms replacement tests (11 passing), and PR-branch Chrome replacement/telephone-input tests (11 passing), all with test retries disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Reuse shared insertion flow and make authoring selectors backport-friendly Replace duplicated telephone policy layer/insertion sequencing with existing helpers. Scope insertion to guideSelectors.insertComponentDialog.dialog and replacement to the Forms content hook; policy controls use cq-dialog and value hooks rather than Coral element tags. Document shared helper reuse. Validate 10 authoring specs: 67 passing and 2 pre-existing skipped tests. One Button cancel-dialog assertion used its existing retry; a standalone rerun passed all 6 active Button tests on their first attempt. Insertion and layer synchronization checks passed across Forms, Sites, fields, layouts, nested wizard panels and Footer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: consume af-core 1.0.10 and cover legacy custom-function access (#2009) Add runtime-only coverage for the legacy _options.parent._setProperty chain. Use the maintained IT page so repeated previews retain working custom-function registration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
@aemforms/af-corefrom^1.0.7to^1.0.10, with the lockfile resolving the published1.0.10package and its required formatter dependency.Extend the existing runtime-only custom-function Cypress spec and fixture with a field inside a visible section and a button whose rule invokes:
The test clicks the rendered button and verifies both model visibility and the hidden section in the DOM. It is active without a feature-toggle gate and does not pass a raw model to the custom function.
Use the repository's maintained IT page for this fixture. With the SDK examples page, subsequent previews failed to resolve custom functions; switching to the IT page makes both consecutive previews and the existing custom-function cases work. Select the existing calculation input by name rather than field registration order now that the fixture contains a nested section.
Related Issue
FORMS-28607
Motivation and Context
Consume the released backward-compatibility fix and add end-to-end coverage for legacy private-member access through the field model exposed in custom functions. This is compatibility coverage, not a recommendation to use private properties or methods.
No authoring UI automation, runtime implementation changes, or package publishing are included.
How Has This Been Tested?
Local AEM author at
http://localhost:4502, Cypress 13.17.0, Chrome 155 headless. Installed the IT apps/content fixtures and rebuilt/deployed the product runtime clientlib for each runtime version.af-core@1.0.7and the corrected IT fixtureaf-core@1.0.10, unchanged fixture and testcd ui.frontend && npm run build:prodcd ui.frontend && npm test -- --runInBandnode --check it/apps/src/main/content/jcr_root/apps/forms-core-components-it/clientlibs/clientlib-it-custom-function/js/functions.jsnode --check ui.tests/test-module/specs/ruleeditor/runtime/customFunction.runtime.cy.jsgit diff --checkCypress command, run from
ui.tests/test-modulefor each runtime (local AEM authentication supplied through the test environment; log/screenshot artifact paths are omitted):The complete repository test suite and authoring suites were not run. CI status is separate from these local results. The optional
no-mistakesCLI is not installed in this environment; validation used the repository's own build and test commands.Screenshots (if appropriate):
Not required for this runtime-only regression.
Types of changes
Checklist:
Added a focused runtime regression; aggregate coverage was not measured. The unchecked all-tests/CI items do not negate the targeted passing results above.