Repository navigation
Merge dev into master: af-core 1.0.10 and authoring test fixes - #2010
Merged
Merged
Conversation
Reuse the existing telephone field with the same default policy, wait for policy save and verify persisted custom patterns before editor navigation, and clean up prepared policy attempts. Keep shared insertion commands unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve insertion of a new telephone field into the blank form. Await policy persistence, actual layer transitions and insertion events; query only the visible insertion dialog and re-query its search input after clearing. Preserve original assertions and wait for the edit dialog to close before cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retry opening the Insert dialog after lost actions, target only visible dialog controls, and wait for layer, insertion and replacement refreshes. Restore the original replace-group policy state using existing editor helpers and named actions. Add a deterministic lost-Insert-click regression with delayed persistence responses. Validation: five Chrome repeats (25 passing), Electron Sites/Forms replacement tests (11 passing), and PR-branch Chrome replacement/telephone-input tests (11 passing), all with test retries disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…endly Replace duplicated telephone policy layer/insertion sequencing with existing helpers. Scope insertion to guideSelectors.insertComponentDialog.dialog and replacement to the Forms content hook; policy controls use cq-dialog and value hooks rather than Coral element tags. Document shared helper reuse. Validate 10 authoring specs: 67 passing and 2 pre-existing skipped tests. One Button cancel-dialog assertion used its existing retry; a standalone rerun passed all 6 active Button tests on their first attempt. Insertion and layer synchronization checks passed across Forms, Sites, fields, layouts, nested wizard panels and Footer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix/telephoneinput policy test
…2009) Add runtime-only coverage for the legacy _options.parent._setProperty chain. Use the maintained IT page so repeated previews retain working custom-function registration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge the latest Adobe
devinto a new branch created from Adobemaster, preserving both branch histories with a merge commit.Source revisions:
dev:f7de780dfa573592b38a7c2189f08abe7dae81d1master:fc839c72ef1bdbbd9dcb6e1d099196d5a625de5fThis promotes the complete pending
devchanges, not only the runtime dependency update:@aemforms/af-core@1.0.10and add the runtime-only custom-function regression for legacy private field-model access.The merge changes nine files and required no conflict resolution or additional source changes.
Related Issue
FORMS-28607
Merged source PRs: #2009 and #2006.
Motivation and Context
Promote the validated
devfixes tomaster. Runtime 1.0.10 restores temporary backward compatibility for legacy private access on the field model exposed in custom functions, with deprecation warnings. The existing custom-function fixture and runtime regression cover the customer-style_options.parent._setProperty('visible', false)access.The additional authoring-test changes are already merged into
devand are included intentionally in this full branch promotion.How Has This Been Tested?
On the promotion merge head, in an isolated worktree with its own dependencies:
npm --prefix ui.frontend test -- --runInBand— passed: 7 suites, 45 tests.npm --prefix ui.frontend run build:prod— passed: standard and XFA production builds and clientlib generation.git diff --check adobe/master HEAD— passed.Both merged source PRs had successful CI when checked, including Java 11/21 builds and Cypress Chrome latest-addon jobs with and without feature toggles.
Maven suites and Cypress suites were not rerun locally on this promotion head. Promotion-PR CI is separate from the successful source-PR checks and must complete before merge.
Screenshots (if appropriate):
Not applicable: branch promotion with no additional UI changes.
Types of changes
Checklist: