Repository navigation
Align documented PHP minimum with the PHP 8.4 requirement - #646
Conversation
composer.json.dist requires PHP ^8.4, but the README still said 7.2, the installer accepted 7.1, and the bug-report template listed 7.2-8.3. - README: require PHP 8.4 - Installer: flag PHP versions below 8.4 on the requirements page - Bug-report template: offer only the supported 8.4 and 8.5
|
Warning This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review. WalkthroughThe PR aligns the issue template, README, and installer check with a PHP minimum of 8.4. It also updates code review guidance and the pull request checklist to target PHP 8.4 and later. ChangesPHP minimum version
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change aligns the documented and checked PHP minimum with 8.4, while allowing installation to proceed after a warning on older versions. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates documentation, issue-report metadata, and the installer requirements diagnostic so the repository consistently communicates and checks PHP 8.4+ support, while leaving historical release notes unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
There was a problem hiding this comment.
🟡 Changes recommended
Contributor documentation and the installer welcome page still advertise obsolete PHP minimums.
2 open findings
What changed in this PR
Aligns user-facing PHP requirements with Composer’s PHP 8.4 minimum.
Changes:
- Updates development and installer requirements to PHP 8.4.
- Limits bug reports to PHP 8.4 and 8.5.
| File | Description |
|---|---|
README.md |
Updates the development requirement. |
htdocs/install/include/functions.php |
Updates installer diagnostics. |
.github/ISSUE_TEMPLATE/bug-report.yml |
Updates supported PHP options. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Here is an outline of what you need to participate in XOOPS development: | ||
|
|
||
| You will need a development environment with at least PHP 7.2 and MySQL 5.6 or equivalent MariaDB. | ||
| You will need a development environment with at least PHP 8.4 and MySQL 5.6 or equivalent MariaDB. |
| function xoPhpVersion() | ||
| { | ||
| if (version_compare(phpversion(), '7.1.0', '>=')) { | ||
| if (version_compare(phpversion(), '8.4.0', '>=')) { |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="htdocs/install/include/functions.php" line_range="233" />
<code_context>
function xoPhpVersion()
{
- if (version_compare(phpversion(), '7.1.0', '>=')) {
+ if (version_compare(phpversion(), '8.4.0', '>=')) {
return xoDiag(1, phpversion());
} else {
</code_context>
<issue_to_address>
**Welcome page permits unsupported PHP**
When a user reads the installer welcome page while using PHP 7.1–8.3, the welcome page says PHP 7.1 or higher meets the requirement, while `xoPhpVersion()` marks PHP below 8.4 as unsupported and Composer rejects it; users are told they can proceed with an unsupported runtime and later encounter the requirement failure.
Update the welcome page’s PHP requirement to match the 8.4 minimum checked by the installer and Composer.
</issue_to_address>
### Comment 2
<location path="README.md" line_range="17" />
<code_context>
Here is an outline of what you need to participate in XOOPS development:
-You will need a development environment with at least PHP 7.2 and MySQL 5.6 or equivalent MariaDB.
+You will need a development environment with at least PHP 8.4 and MySQL 5.6 or equivalent MariaDB.
You will need to interact with [GitHub.com](https://guides.github.com/)
</code_context>
<issue_to_address>
**Contributor guidance targets unsupported PHP**
When a contributor follows the repository’s AI, Copilot, or CodeRabbit coding or review guidance, the guidance still presents PHP 7.2 as supported, and some instructions prohibit PHP 8+ features, so contributors target or test a runtime Composer rejects and avoid features supported by the project’s PHP 8.4 minimum.
Update the AI and review instructions, including the reusable Copilot template, to state the PHP 8.4 minimum and remove incompatible PHP 7.2 guidance.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: htdocs/install/include/functions.php:233, README.md:17
| function xoPhpVersion() | ||
| { | ||
| if (version_compare(phpversion(), '7.1.0', '>=')) { | ||
| if (version_compare(phpversion(), '8.4.0', '>=')) { |
There was a problem hiding this comment.
🟡 Medium · Welcome page permits unsupported PHP
When a user reads the installer welcome page while using PHP 7.1–8.3, the welcome page says PHP 7.1 or higher meets the requirement, while xoPhpVersion() marks PHP below 8.4 as unsupported and Composer rejects it; users are told they can proceed with an unsupported runtime and later encounter the requirement failure.
Update the welcome page’s PHP requirement to match the 8.4 minimum checked by the installer and Composer.
Prompt for AI agents
In `htdocs/install/include/functions.php` at line 233:
**Welcome page permits unsupported PHP**
When a user reads the installer welcome page while using PHP 7.1–8.3, the welcome page says PHP 7.1 or higher meets the requirement, while `xoPhpVersion()` marks PHP below 8.4 as unsupported and Composer rejects it; users are told they can proceed with an unsupported runtime and later encounter the requirement failure.
Update the welcome page’s PHP requirement to match the 8.4 minimum checked by the installer and Composer.| Here is an outline of what you need to participate in XOOPS development: | ||
|
|
||
| You will need a development environment with at least PHP 7.2 and MySQL 5.6 or equivalent MariaDB. | ||
| You will need a development environment with at least PHP 8.4 and MySQL 5.6 or equivalent MariaDB. |
There was a problem hiding this comment.
🟡 Medium · Contributor guidance targets unsupported PHP
When a contributor follows the repository’s AI, Copilot, or CodeRabbit coding or review guidance, the guidance still presents PHP 7.2 as supported, and some instructions prohibit PHP 8+ features, so contributors target or test a runtime Composer rejects and avoid features supported by the project’s PHP 8.4 minimum.
Update the AI and review instructions, including the reusable Copilot template, to state the PHP 8.4 minimum and remove incompatible PHP 7.2 guidance.
Prompt for AI agents
In `README.md` at line 17:
**Contributor guidance targets unsupported PHP**
When a contributor follows the repository’s AI, Copilot, or CodeRabbit coding or review guidance, the guidance still presents PHP 7.2 as supported, and some instructions prohibit PHP 8+ features, so contributors target or test a runtime Composer rejects and avoid features supported by the project’s PHP 8.4 minimum.
Update the AI and review instructions, including the reusable Copilot template, to state the PHP 8.4 minimum and remove incompatible PHP 7.2 guidance.![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
.coderabbit.yaml and copilot-instructions.md still described a PHP 7.2-8.5 target, so reviewers flagged PHP 8 syntax as errors.
|
|
composer.json.distrequires PHP^8.4, but the rest of the repo still advertised much older versions, so someone could follow the docs onto a PHP that Composer then refuses.xoPhpVersion()flags PHP below 8.4 on the requirements page (was 7.1). It is the same red/green check and still does not block installationdocs/release_notes.txtis left as is; it is the historical Alpha 1 announcement.Summary by Sourcery
Align repository documentation, tooling guidance, and installer checks with the PHP 8.4 minimum requirement.
Enhancements:
Documentation:
Summary by CodeRabbit