Repository navigation
virtualbox: VBoxVMI pause, resume and vCPU count - #305
Merged
Merged
Conversation
pause and resume go through the VBoxVMI PAUSE and RESUME commands: VirtualBox's standard pause, so the VM shows as Paused in VBoxManage and the GUI, synchronous (every vCPU stopped when pause returns) and idempotent (one resume undoes any number of pauses, by anyone). The vCPU count comes from VCPU_COUNT at connect, like the max physical address. rs-vboxvmi is bumped to 622c077 for the new commands. mem-dump.py no longer requires --no-pause for VBoxVMI. The driver and test docs list pause/resume and vCPU count as supported, and the VBoxVMI test filters cover the pause, resume and vCPU tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sume The server also refuses during a configuration change and, for resume, on a teleport source or target. rs-vboxvmi is bumped to 2b71bb8 for the matching error message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283.
pause/resume(synchronous, idempotent; VBoxManage shows Paused) andget_vcpu_count(read once at connect) via rs-vboxvmi2b71bb8.mem-dump.pyno longer requires--no-pausefor VBoxVMI; driver docs list the states the server refuses.Server: Wenzel/virtualbox#6 (merged into
vmi/vboxvmi).Verified live (
VBOX_TEST_METHOD=vboxvmi, 1 and 2 vCPUs):virtualbox_vcpu_count_matches_vmm,virtualbox_pause_stops_vcpus,virtualbox_pause_idempotent_and_visible,init,get_vcpu_count,double_pause,pause_resume,multiple_pause_resume,double_resume,virtualbox_read_*. fmt, clippy-D warnings(virtualbox-api, virtualbox-vmi, both with --tests),virtualbox_errorspass.