Repository navigation
Retry a missing stock gauge every 250 ms and notify electric-material bindings once - #178
Merged
Merged
Conversation
… bindings once When the game's own speedometer is hidden, the direct gauge reader found no child object on every HUD tick and ran its discovery again each time. The resolver now remembers the missing gauge for the same module, source, car and powertrain and retries after 250 ms; a new car, source or session reads at once. Gauge views bind IsElectricPowertrain, which changes only when the powertrain does, instead of re-evaluating the whole native frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the game's own speedometer is hidden, or the direct gauge object is absent on the current build, the direct gauge resolver re-ran its discovery on every HUD tick and failed every time. On 6.483.970.0 every PC is in this state today.
Changes
NativeHudMemoryResolverremembers a missing gauge for the same module, source, car and powertrain and retries after 250 ms. A new car, source or session reads at once, and a successful read resumes normal sampling.DiagnosticsViewModel.IsElectricPowertrain, which changes only when the powertrain does, instead of re-evaluatingNativeGaugeFrame.IsElectricon every frame.Verification
dotnet format whitespace --verify-no-changesclean.Test-AppBehavior.ps1 -BaseRevision main) on that build: Core 780, Telemetry 96, Update 184, Updater 76 and App 1295 tests passed, 0 failed.NativeGaugeDirectResolverTestsandDiagnosticsViewModelTestscover the retry window, immediate recovery on a new context, and the single electric-material notification.