Repository navigation
Conversation
The analogue tire temperature gauge binds IsElectricPowertrain since the gauge views stopped re-evaluating NativeGaugeFrame.IsElectric on every frame, and the setup wizard's Data Out test no longer records its guidance checkpoint as a timeout. Both tests run only in the nightly suite, so the pull request gate did not select them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two nightly-only tests encode behavior that 2.7.4 changed on purpose; the PR gate selects tests by changed-file stem, so neither ran on the fixing PRs.
ElectricNativeRoutingTests.TireTemperatureGaugesShareTheNativeRootAndRemainAvailableForElectricLayoutsasserted the analogue tire gauge'sIsElectricMaterialbinding path. Retry a missing stock gauge every 250 ms and notify electric-material bindings once #178 bindsIsElectricPowertrain, which changes only with the powertrain; the expectation follows.SupplementaryOperationFailureTests.SetupTimeoutReportsWhatTheReceiverActuallyObservedexpected the 45-second guidance checkpoint to record atimeoutoutcome with the receiver's reason. Stop recording the setup test's 45 s checkpoint as a timeout #180 stopped recording the checkpoint (a player who keeps going has not failed the test). The theory becomesCancellingAfterTheGuidanceCheckpointRecordsNoTimeout: for the same receiver states, cancelling after the checkpoint records no timeout and no incident, onlycancelled. The real timeout path (listener stopped) is covered bySetupTelemetryTests.Verification
Test-AppBehavior.ps1 -Fullon main plus Mask the game's thread-local slot operand in the gauge field templates #184 and Recognize the Steam 6.483 tune benchmark #185: Core 784, Telemetry 96, Update 184, Updater 76 passed; App 6125 of 6130 passed. The five failures were these two tests (four cases) andWpfStyleRuntimeTests.ApplicationStylesAndNativeControlsPassRuntimeChecks, which failed on the maintainer PC at a desktop-dependent assertion (CalmSidebarTests.AssertUniformDockItemslabel fit, once atHudNativeHostRecoveryTests.AssertHostRebuildOnAttach); see the release PR for its CI nightly result.ElectricNativeRoutingTests,SupplementaryOperationFailureTestsandSetupTelemetryTests: 90 passed, 0 failed.