Repository navigation
Keep engaged plot drags continuous through the press position - #32
Merged
Merged
Conversation
The initial click tolerance also discarded movement after a drag had engaged. Returning the pointer to its press position therefore retained the preceding pan offset. Apply tolerance only while the press remains a click candidate; subsequent deltas continue through the existing pan and range-clamping paths. Add event regressions for sparse return and dense crossing sequences with local and shared time axes, no drag-generated click, and retained click slop. The sparse sequence reproduced a [900,1900] range instead of [1000,2000] before the fix. Final validation uses the configured public pull-request CI.
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning an engaged main-plot drag to its original press position discarded the returning movement and retained the preceding pan offset. Apply the click tolerance only while the gesture remains a click candidate, preserving the existing pan/clamp and click semantics.
Add sparse return and dense crossing event regressions with local and shared time axes, plus a check that genuine click slop still leaves the range unchanged. The pre-fix offscreen fixture reproduced press x=100 → move x=120 → return x=100 leaving [900,1900] instead of [1000,2000] (39 passing cases, one failing regression).
Independent source review found no material issues. All eight public CI jobs passed, including PlotInteractionItem in each configuration:
No application UI or visual/interaction-feel certification is claimed.