Repository navigation
Fix value-axis jumps when enabling drag modifiers - #34
Merged
Merged
Conversation
Advance the vertical pointer reference on every engaged drag move so Ctrl and Alt consume only new movement. Keep initial click tolerance and horizontal routing unchanged. Add regressions for modifier transitions, re-enablement, stationary and reverse movement, local/shared time axes, and click tolerance. Fixes #33.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling Ctrl or Alt during an existing plot drag reused a stale vertical pointer reference, applying earlier unmodified movement to the value axis. The reported sequence moved the lower value limit by 20.2 units instead of 0.2.
Advance the vertical reference on every engaged move while applying value-axis panning only when Ctrl or Alt is held. Preserve initial click tolerance, horizontal routing and the existing update order before value-limit signals.
Add production interaction regressions covering both modifiers, release/re-enablement, stationary changes, reverse movement, local/shared time axes and click tolerance.
Validation
Native checks used Qt 6.12.0, GCC 14.2, the standard CMake build and the maintained offscreen
PlotInteractionItemtest target, with text rendering disabled:20.2instead of0.2PR #32 merges without conflicts; its return-through-press-position and genuine-click regressions pass in the combined run. The existing production event handlers and widget range calculations are exercised. Independent source review and
git diff --checkalso passed.Fixes #33. Related: #32.