Skip to content

ci: support optional pr-number and commit-sha in reusable governance + run on draft PRs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damaz91 wants to merge 2 commits into
base: main
Choose a base branch
from
+35 −3
Open

ci: support optional pr-number and commit-sha in reusable governance + run on draft PRs #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6042f2a
ci: support optional pr-number and commit-sha in reusable governance
damaz91 Jun 30, 2026
945b2e9
Allow job to run for draft pull requests
damaz91 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions .github/workflows/reusable-governance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ on:
required: false
type: string
description: "Optional path to the governance rules configuration file (e.g., .github-central/org-tools/governance/rules/python-sdk-rules.yml). If not provided, resolved via --repo mapping."
pr-number:
required: false
type: number
description: "Optional PR number. Falls back to pull_request context if not provided."
commit-sha:
required: false
type: string
description: "Optional commit SHA. Falls back to pull_request context if not provided."
secrets:
ORG_READ_TOKEN:
required: true
Expand All @@ -30,7 +38,6 @@ jobs:
evaluate:
name: Approvals
runs-on: ubuntu-latest
if: github.event.pull_request.draft == false
steps:
# 1. Check out the caller repository (the PR code)
- name: Check out PR code
Expand All @@ -54,6 +61,17 @@ jobs:
run: |
set +e

# Resolve PR number (input vs event fallback)
PR_NUMBER="${{ inputs.pr-number }}"
if [ -z "$PR_NUMBER" ]; then
PR_NUMBER="${{ github.event.pull_request.number }}"
fi

if [ -z "$PR_NUMBER" ]; then
echo "::error::PR number could not be resolved."
exit 1
fi

RULES_FILE_ARG=""
if [ -n "${{ inputs.rules-file }}" ]; then
RULES_FILE_ARG="--rules-file ${{ inputs.rules-file }}"
Expand All @@ -63,7 +81,7 @@ jobs:
--token "${{ secrets.ORG_READ_TOKEN }}" \
--org "${{ github.repository_owner }}" \
--repo "${{ github.repository }}" \
--pr "${{ github.event.pull_request.number }}" \
--pr "$PR_NUMBER" \
$RULES_FILE_ARG


Expand Down Expand Up @@ -108,11 +126,25 @@ jobs:
// Construct the exact URL to the current GitHub Actions workflow run logs
const runUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;

// Resolve SHA (input vs event fallback)
let sha = '${{ inputs.commit-sha }}';
if (!sha) {
sha = context.payload.pull_request ? context.payload.pull_request.head.sha : null;
}
if (!sha && context.payload.workflow_run) {
sha = context.payload.workflow_run.head_sha;
}

if (!sha) {
core.setFailed('SHA could not be resolved.');
return;
}

// Post the status to the specific commit hash
await github.rest.repos.createCommitStatus({
owner: context.repo.owner,
repo: context.repo.repo,
sha: context.payload.pull_request.head.sha,
sha: sha,
state: state,
context: 'Governance / Approvals',
description: description,
Expand Down
Loading