ci: support optional pr-number and commit-sha in reusable governance + run on draft PRs#34
Open
damaz91 wants to merge 2 commits into
Open
Conversation
Remove condition to run job only for non-draft PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
reusable-governance.ymlworkflow to accept optionalpr-numberandcommit-shainputs. If these inputs are not provided, it falls back to the defaultpull_requestcontext.This allows the workflow to be triggered from other events (like
workflow_runorrepository_dispatch) where thepull_requestcontext might not be directly available, but the PR number and commit SHA are known.It also allow the governance scripts to run for draft PRs, instead of skipping it.
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
None.
Checklist
!for breaking changes).