-
Notifications
You must be signed in to change notification settings - Fork 8
chore: add governance rules for all UCP repos #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3704fa2
chore: add governance rules for all UCP repos
damaz91 c693270
chore: add target repository URL
damaz91 758db56
SDKs only need 1 approval
damaz91 aaf4cfe
add rules for meeting-minutes + add missing files to existing rules
damaz91 30474bf
set 1 approval for meeting-minutes
damaz91 2107bb6
add .codespellignore to infra and tooling
damaz91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Target Repository: conformance | ||
| # Repository URL: https://github.com/Universal-Commerce-Protocol/conformance | ||
| --- | ||
| rules: | ||
| # --------------------------------------------------------- | ||
| # Governance | ||
| # --------------------------------------------------------- | ||
| - name: "governance_and_licensing" | ||
| patterns: | ||
| - "LICENSE" | ||
| requires: | ||
| # Strictly Governance Council (L4) | ||
| - team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Infrastructure, Tooling & Configuration | ||
| # --------------------------------------------------------- | ||
| - name: "infra_and_tooling" | ||
| patterns: | ||
| - ".cspell.json" | ||
| - ".cspell/**" | ||
| - ".github/**" | ||
| - ".gitignore" | ||
| - ".pre-commit-config.yaml" | ||
| - "README.md" | ||
| - "*.py" | ||
| - "pyproject.toml" | ||
| - "shopping-agent-test.json" | ||
| - "test_data/**" | ||
| requires: | ||
| # Grants access to devops (L1), maintainers (L2), tech-council (L3), | ||
| # and governance-council (L4) | ||
| - min_team: "devops-maintainers" | ||
| min_approvals: 2 | ||
|
|
||
| fallback: | ||
| requires: | ||
| # Default for all files (*). | ||
| # Strictest rule possible | ||
| - min_team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| proxy_reviewers: | ||
| - amithanda | ||
|
|
||
| team_hierarchy: | ||
| devops-maintainers: 1 | ||
| maintainers: 2 | ||
| tech-council: 3 | ||
| governance-council: 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Target Repository: js-sdk | ||
| # Repository URL: https://github.com/Universal-Commerce-Protocol/js-sdk | ||
| --- | ||
| rules: | ||
| # --------------------------------------------------------- | ||
| # Governance | ||
| # --------------------------------------------------------- | ||
| - name: "governance_and_licensing" | ||
| patterns: | ||
| - "LICENSE" | ||
| requires: | ||
| # Strictly Governance Council (L4) | ||
| - team: "governance-council" | ||
| min_approvals: 1 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Infrastructure, Tooling & Configuration | ||
| # --------------------------------------------------------- | ||
| - name: "infra_and_tooling" | ||
| patterns: | ||
| - ".codespellignore" | ||
| - ".github/**" | ||
| - ".gitignore" | ||
| - ".pre-commit-config.yaml" | ||
| - ".prettierrc" | ||
| - "README.md" | ||
| - "generate_models.sh" | ||
| - "index.ts" | ||
| - "package-lock.json" | ||
| - "package.json" | ||
| - "scripts/**" | ||
| - "src/**" | ||
| - "tsconfig.cjs.json" | ||
| - "tsconfig.esm.json" | ||
| - "tsconfig.json" | ||
| - "tsconfig.types.json" | ||
| requires: | ||
| # Grants access to devops (L1), maintainers (L2), tech-council (L3), | ||
| # and governance-council (L4) | ||
| - min_team: "devops-maintainers" | ||
| min_approvals: 1 | ||
|
|
||
| fallback: | ||
| requires: | ||
| # Default for all files (*). | ||
| # Strictest rule possible | ||
| - min_team: "governance-council" | ||
| min_approvals: 1 | ||
|
|
||
| proxy_reviewers: | ||
| - amithanda | ||
|
|
||
| team_hierarchy: | ||
| devops-maintainers: 1 | ||
| maintainers: 2 | ||
| tech-council: 3 | ||
| governance-council: 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # Target Repository: meeting-minutes | ||
| # Repository URL: https://github.com/Universal-Commerce-Protocol/meeting-minutes | ||
| --- | ||
| rules: | ||
| # --------------------------------------------------------- | ||
| # Governance | ||
| # --------------------------------------------------------- | ||
| - name: "governance_and_licensing" | ||
| patterns: | ||
| - "LICENSE" | ||
| requires: | ||
| # Strictly Governance Council (L4) | ||
| - team: "governance-council" | ||
| min_approvals: 1 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Technical Council Minutes | ||
| # --------------------------------------------------------- | ||
| - name: "tech_council_minutes" | ||
| patterns: | ||
| - "tc/**" | ||
| requires: | ||
| # Grants access to tech-council (L3) and governance-council (L4) | ||
| - min_team: "tech-council" | ||
| min_approvals: 1 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Governing Council Minutes | ||
| # --------------------------------------------------------- | ||
| - name: "governance_council_minutes" | ||
| patterns: | ||
| - "gc/**" | ||
| requires: | ||
| # Grants access to governance-council (L4) | ||
| - min_team: "governance-council" | ||
| min_approvals: 1 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Infrastructure, Tooling & General Files | ||
| # --------------------------------------------------------- | ||
| - name: "infra_and_tooling" | ||
| patterns: | ||
| - ".codespellignore" | ||
| - ".github/**" | ||
| - ".gitignore" | ||
| - ".pre-commit-config.yaml" | ||
| - "README.md" | ||
| - "CONTRIBUTING.md" | ||
| - "SECURITY.md" | ||
| excludes: | ||
| - ".github/CODEOWNERS" | ||
| requires: | ||
| # Grants access to devops (L1), maintainers (L2), tech-council (L3), | ||
| # and governance-council (L4) | ||
| - min_team: "devops-maintainers" | ||
| min_approvals: 1 | ||
|
|
||
| fallback: | ||
| requires: | ||
| # Default for all files (*). | ||
| # Strictest rule possible | ||
| - min_team: "governance-council" | ||
| min_approvals: 1 | ||
|
|
||
| proxy_reviewers: | ||
| - amithanda | ||
|
|
||
| team_hierarchy: | ||
| devops-maintainers: 1 | ||
| maintainers: 2 | ||
| tech-council: 3 | ||
| governance-council: 4 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Target Repository: samples | ||
| # Repository URL: https://github.com/Universal-Commerce-Protocol/samples | ||
| --- | ||
| rules: | ||
| # --------------------------------------------------------- | ||
| # Governance | ||
| # --------------------------------------------------------- | ||
| - name: "governance_and_licensing" | ||
| patterns: | ||
| - "LICENSE" | ||
| requires: | ||
| # Strictly Governance Council (L4) | ||
| - team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Infrastructure, Tooling & Configuration | ||
| # --------------------------------------------------------- | ||
| - name: "infra_and_tooling" | ||
| patterns: | ||
|
damaz91 marked this conversation as resolved.
|
||
| - ".codespellignore" | ||
| - ".cspell.json" | ||
| - ".cspell/**" | ||
| - ".github/**" | ||
| - ".gitignore" | ||
| - ".pre-commit-config.yaml" | ||
| - ".prettierrc" | ||
| - "README.md" | ||
| - "SECURITY.md" | ||
| - "a2a/**" | ||
| - "rest/**" | ||
| requires: | ||
| # Grants access to devops (L1), maintainers (L2), tech-council (L3), | ||
| # and governance-council (L4) | ||
| - min_team: "devops-maintainers" | ||
| min_approvals: 2 | ||
|
|
||
| fallback: | ||
| requires: | ||
| # Default for all files (*). | ||
| # Strictest rule possible | ||
| - min_team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| proxy_reviewers: | ||
| - amithanda | ||
|
|
||
| team_hierarchy: | ||
| devops-maintainers: 1 | ||
| maintainers: 2 | ||
| tech-council: 3 | ||
| governance-council: 4 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| # Target Repository: ucp | ||
| # Repository URL: https://github.com/Universal-Commerce-Protocol/ucp | ||
| --- | ||
| rules: | ||
| # --------------------------------------------------------- | ||
| # Governance | ||
| # --------------------------------------------------------- | ||
| - name: "governance_and_licensing" | ||
| patterns: | ||
| - "LICENSE" | ||
| - "MAINTAINERS.md" | ||
| requires: | ||
| # Strictly Governance Council (L4) | ||
| - team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Core Protocol | ||
| # --------------------------------------------------------- | ||
| - name: "core_protocol_src" | ||
| patterns: | ||
|
damaz91 marked this conversation as resolved.
|
||
| - "source/**" | ||
| requires: | ||
| # Grants access to governance-council (L4) | ||
| - min_team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Specific Documentation | ||
| # --------------------------------------------------------- | ||
| - name: "documentation_spec" | ||
| patterns: | ||
| - "docs/specification/**" | ||
| requires: | ||
| # Grants access to maintainers (L2), tech-council (L3) and | ||
| # governance-council (L4) | ||
| - min_team: "maintainers" | ||
| min_approvals: 2 | ||
|
|
||
| # --------------------------------------------------------- | ||
| # Infrastructure, Tooling, Configuration & General Docs | ||
| # --------------------------------------------------------- | ||
| - name: "infra_and_tooling" | ||
| patterns: | ||
|
damaz91 marked this conversation as resolved.
|
||
| - ".github/**" | ||
| - "scripts/**" | ||
| - "generated/**" | ||
| - "hooks.py" | ||
| - "main.py" | ||
| - ".cspell/**" | ||
| - ".cspell.json" | ||
| - ".pre-commit-config.yaml" | ||
| - ".prettierignore" | ||
| - ".prettierrc" | ||
| - ".stylelintrc.json" | ||
| - "biome.json" | ||
| - "mkdocs.yml" | ||
| - ".gitignore" | ||
| - ".linkignore" | ||
| - "AGENTS.md" | ||
| - "CLAUDE.md" | ||
| - "pyproject.toml" | ||
| - "uv.lock" | ||
| - "package.json" | ||
| - "package-lock.json" | ||
| - "docs/**" | ||
| excludes: | ||
| - "docs/specification/**" # Covered by Documentation Specification | ||
| - ".github/CODEOWNERS" | ||
| requires: | ||
| # Grants access to devops (L1), maintainers (L2), tech-council (L3), | ||
| # and governance-council (L4) | ||
| - min_team: "devops-maintainers" | ||
| min_approvals: 2 | ||
|
|
||
| fallback: | ||
| requires: | ||
| # Default for all files (*). | ||
| # Strictest rule possible | ||
| - min_team: "governance-council" | ||
| min_approvals: 2 | ||
|
|
||
| proxy_reviewers: | ||
| - amithanda | ||
|
|
||
| team_hierarchy: | ||
| devops-maintainers: 1 | ||
| maintainers: 2 | ||
| tech-council: 3 | ||
| governance-council: 4 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.