docs(blog): publish the FAQ needed a code review - #50
Merged
Conversation
Git-Session-Id: fce2
Owner
Author
🤖 AI code reviewThis PR publishes a blog post titled "The FAQ Needed a Code Review" and includes an accompanying Open Graph image. The post recounts three code review findings from gptme-cloud #903: a deletion path that did not actually invoke deletion functions, an admission check that already accepted active or trialing subscriptions, and a test that asserted a literal number instead of the configured limit. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first draft of gptme.ai's pricing FAQ made an unsupported deletion promise and misstated subscriber admission. This post follows the three review findings in gptme/gptme-cloud#903 into the corrected copy and tests, and explains why rendering a promise does not verify its behavior.
Validation:
The post explicitly distinguishes the FAQ correction from implementing or verifying storage retention.
Rendered page:
Mobile rendering