Conversation
milando12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go NIP execution receives an execution mode, but Bor cannot independently relax base-fee, priority-fee or funding checks. Add three opt-in VM flags so the consumer can apply that mode without rewriting fee values or changing native RPC defaults.
Below-base-fee transactions pay no negative beneficiary tip. Simulation funding uses the effective gas charge and preserves value transfer and unused-gas refunds. Ordinary execution with all flags false keeps its existing checks and accounting.
Validated with
GOMAXPROCS=4 mise exec -- go test -p=2 -count=1 ./core -run '^TestExecution'(passed). Tests exercise the actual state transition, fee opcodes, independent checks, transfer balances, refunds and default behavior.Companion tenderly-core#26272 enables these flags only for NIP Execute and BuildBlock. net-nitro#6 supplies the equivalent Arbitrum controls. Native call, estimate and trace paths are outside this change.