Repository navigation
fix(editor): keep input method composition out of auto-pairing and undo - #3579
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With a dead-key layout (U.S. International, Brazilian),
'then Space typed'''in the SQL editor, and"typed""". Every composition keystroke ran through the typing filters: the commit replaced the marked'with', and the pair filter read a quote replacing a range as "wrap the selection". Each composition stage also went into the undo history.Change
NSTextViewdoes.Verified
CompositionTypingTestsandCompositionUndoTestsfail on main and pass here. The undo, click and unmark behavior matchesNSTextView, measured with a probe.Not in this PR
NSTextViewtakes one.Fixes #3458