Repository navigation
feat(linux): make the error details the app writes translatable - #3555
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release criterion 9: no message the user cannot have translated. Error details from the core crates still reached the app as English: CSV import reasons, cell and JSON parse errors, the type and default parsers, the keyring, certificate files and a driver's unsupported feature.
Change
UnsupportedFeature, a JSON line and column, the CSV line, anio::ErrorKind. The app writes each sentence through gettext.trace.Verified
New tests pin each mapping. Changed on purpose:
a_backend_error_keeps_its_detail(nowa_backend_error_shows_the_services_words_and_never_oo7s),a_file_with_no_header_gets_names_from_the_positions,the_message_says_what_happened_in_words_not_the_error_text,a_bad_row_names_its_line_in_the_file.