Repository navigation
ci: parse xcresult bundles in one place - #3480
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
summarize-xcresult.shandverify.sheach parsed result bundles, and they drifted. The CI summary printed 0-based lines, one line high, listed "Testing cancelled because the build failed." as a build error, and counted a "System Failures" runner failure as a failed test, which hid "executed no test".Change
scripts/lib/xcresult-cases.py(stdlib, Python 3.9) reads bundles and xunit files for both:tallyanderrorsforverify.sh,summaryfor CI.summarize-xcresult.shcalls it;platform-apple.shdrops its jq, awk and xmllint parsers.verify.shnow says to rerungenerate-project.shwhen a base xcconfig is missing.Verified
scripts/lib/test_xcresult_cases.py, now run by Repo Hygiene. Old and new parsers agree on real bundles (retries, nested and parameterized Swift Testing, a failed build, a CI runner failure) apart from the fixes above.verify.sh test SQLEscapingTests SpatialProjectionTestspasses through it.Not in this PR
detect-changed-paths.sh'soraclesuite does not watchscripts/lib/xcresult-cases.pyyet.