Repository navigation
ci: cap build errors in the parser instead of piping into head - #3490
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
report_build_errorsin verify.sh pipedxcresult-cases.py errorsintohead -12. Python ignores SIGPIPE, so a test build with a few hundred errors printed aBrokenPipeErrortraceback onceheadclosed the pipe. The verdict stayed right, but the output looked like a parser crash. The jq it replaced in #3480 died silently.Change
xcresult-cases.py errorstakes--limit <n>and stops after n errors.--limit 12and drops thehead.Verified
scripts/lib/test_xcresult_cases.pycovers theerrorsoutput (Broken.swift:4: message), the limit, and a bad limit.verify.sh parseon a stub bundle with 1000 build errors prints 12 and no traceback; on main it prints the traceback.Not in this PR
oraclesuite inscripts/ci/detect-changed-paths.shstill watchessummarize-xcresult.shbut notscripts/lib/xcresult-cases.py.