Repository navigation
refactor(linux): finish remediation steps 56 to 66 - #3433
Merged
Merged
Conversation
Ctrl+S is a window shortcut, so it reached the tab while its review was open and stacked a second review of the same changes.
Declining a review already keeps the window open, so the tabs after it no longer show their reviews or start saves.
A draft edited under the open review was caught only inside the write, which showed an untranslated error. The save now plans again once the review is answered and says the changes were edited.
# Conflicts: # linux/CHANGELOG.md # linux/crates/app/src/services/mod.rs # linux/crates/app/src/ui/connection_row.rs # linux/crates/app/src/ui/session_window/imp.rs # linux/crates/app/src/ui/session_window/mod.rs # linux/crates/app/src/ui/session_window/session_window_command.rs # linux/crates/app/src/ui/session_window/session_window_input.rs # linux/crates/app/src/ui/session_window/tests.rs # linux/po/POTFILES.in
# Conflicts: # linux/CHANGELOG.md # linux/crates/app/src/workspace/mod.rs
# Conflicts: # linux/CHANGELOG.md
# Conflicts: # linux/CHANGELOG.md # linux/crates/app/Cargo.toml # linux/crates/app/src/application/app_services.rs # linux/crates/app/src/application/imp.rs # linux/crates/app/src/ui/session_window/mod.rs # linux/crates/app/src/ui/session_window/session_window_input.rs # linux/crates/app/src/workspace/workspace_store.rs
AdwAlertDialog closes itself before it emits a response, so a second close found it gone and logged a critical when animations were off.
Rows are still keyed in the identity the save path binds (the primary key in column order); RowKeyBuilder takes the page's identity range once saves plan with the page identity.
AdwAlertDialog emits closed before the response a click chose, and the closed handler answered Cancel first. Answer through workspace::respond, which defers its close response to an idle callback.
# Conflicts: # linux/CHANGELOG.md
cargo2rpm leaves out the workspace's own crates by matching the working directory in their path, so from crates/app it kept the other members and the Provides generator failed on them after %check.
rpmbuild --rebuild removes the spec it unpacks into SPECS, which was the copy build-rpm.sh then gave rpmlint, so a build that passed %check failed at the lint.
GTK 4.22 holds a removed widget that held the focus until the window's next paint, so the drop check passed only when a frame came first, and failed on the Fedora 44 app suite. The frame wait is one helper now.
rpmlint warned files-duplicate: %license LICENSE copied the file Meson already installs where the About dialog reads it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Steps 56 to 66 of
linux/docs/plan-2026-09-14-audit-remediation.md. Controls used sentence case or had no accessible name, the app shipped only as a Flatpak, CI missed supply chain and Flatpak breakage, and the docs had drifted from the code.Change
linux-v*tags (ADR 0017).too_many_lines, and the files past it are split by domain.Verified
fmt and both clippy runs in
ubuntu:26.04; the POT infedora:44; the rpm passed every Meson suite in%check. Draft until the deb and rpm finish building, linting and the start test.Not in this PR
mainfor the weekly run (W8-27) follows this PR.