Repository navigation
fix(linux): address the review findings on steps 56 to 66 - #3434
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
release-linux.ymlpublishes only when the tagged commit is on theLINUX_BRANCHbranch (linuxwhen unset).linux-releaseenvironment, so the COPR token can be limited tolinux-v*tags.--latest=false).linux-packages.ymlorrelease-linux.ymlchanges, so zizmor audits them.group_round_trips_through_connections_documentchanges to match.SavedConnectionEditorruns an edit and a copy one at a time, so two windows saving the same connection cannot leave one edit's endpoint with the other's password.linuxCI from refactor(linux): finish remediation steps 56 to 66 #3433:sshor askpass script write it throughtablepro_test_support::write_executable, so a fork from another test thread cannot hold it open and make exec fail with ETXTBSY (a_failing_lookup_and_a_jump_loop_resolve_to_nothing). The askpass test's retry loop is gone.libGLESv2.so.2: GTK's renderer loads it through libepoxy, which aborts without it, and on Fedora 44 neither gtk4 nor libepoxy declares it, so a default install aborted at startup.dbus-run-sessionwithGNOTIFICATION_BACKEND=freedesktop, so the notification test has a bus inside the Flatpak build sandbox and never reaches the desktop it runs on.Verified
tablepro-storage(167) andtablepro-test-support,tablepro-ssh,tablepro-test-fixtures(159) inubuntu:26.04.Before the first tag
linux-releaseenvironment, allow onlylinux-v*tags, and moveCOPR_CONFIGinto it.